Skip to content

Conversation

@OskarStark
Copy link
Collaborator

Library packages should not commit composer.lock to allow consumers to resolve dependencies according to their needs.

Library packages should not commit composer.lock to allow
consumers to resolve dependencies according to their needs.
@OskarStark OskarStark changed the title chore: Remove composer.lock and add to gitignore chore: Remove composer.lock and add to .gitignore Jan 9, 2026
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.92%. Comparing base (e1641e9) to head (a539b13).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #87   +/-   ##
=========================================
  Coverage     93.92%   93.92%           
  Complexity      493      493           
=========================================
  Files            79       79           
  Lines          1630     1630           
=========================================
  Hits           1531     1531           
  Misses           99       99           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@OskarStark OskarStark merged commit 19b4385 into storyblok:master Jan 9, 2026
5 checks passed
@silasjoisten
Copy link
Collaborator

That was not such a good idea. the composer.lock was excluded from the page see .gitattributes now i have different package versions then the CI which makes it hard to debug.

@silasjoisten
Copy link
Collaborator

@OskarStark please revert

@OskarStark OskarStark deleted the remove-composer-lock branch January 12, 2026 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants