Repository navigation
Conversation
馃 Changeset detectedLatest commit: 0b4468a The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Reanimated 4.6+ ignores the dependency array on native, where the
worklets plugin already captures the closure, and warns about it
("Dependencies should only be used on the web"). The array is kept on
web, where it is still used when the worklets babel plugin does not run:
without it a production web build would compute maxHeight only once and
clip the panel on a narrow viewport.
Adds a regression test that renders MobileAddonsPanel and asserts
useAnimatedStyle receives no dependency array on native and the
dependencies on web.
Fixes #943
(cherry picked from commit 590b304)
dannyhw
force-pushed
the
dannyhw/fix/reanimated-deps-warning-v10
branch
from
October 24, 2026 13:54
e935995 to
0b4468a
Compare
dannyhw
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #943
Backport of #948 to
v10-stable. Stacked on #949, because it reuses that PR's jest setup. It will retarget tov10-stableonce #949 merges. Only the top commit belongs to this PR.What I did
MobileAddonsPanelnow passes itsuseAnimatedStyledependency array only on web (Platform.OS === 'web' ? [...] : undefined). On native, Reanimated 4.6+ ignores the array and warns ("Dependencies should only be used on the web"). Web behaviour is unchanged. The source, test and changeset are byte-identical to #948. See #948 for details.How to test
pnpm -F @storybook/react-native-ui test: onv10-stablethe iOS and Android cases fail withReceived: [{"value": 0}, 844, 34]. They pass here, and the web case passes on both branches. All gates pass.