CSF: Improve error handling in csf factories codemod #48557
Triggered via pull request
September 5, 2025 18:00
yannbf
Status
Failure
Total duration
23m 14s
Artifacts
–
tests-unit.yml
on: pull_request
Core Unit Tests, windows-latest
23m 7s
Annotations
5 errors
|
Core Unit Tests, windows-latest
Process completed with exit code 1.
|
|
src/codemod/helpers/story-to-csf-factory.test.ts > stories codemod > typescript > should not complete transformation if no stories are not transformed:
code/lib/cli-storybook/src/codemod/helpers/story-to-csf-factory.test.ts#L691
AssertionError: expected 'export default {\n title: \'Componen…' to deeply equal 'export default {\n title: \'Componen…'
- Expected
+ Received
@@ -4,5 +4,6 @@
export const A = {};
// not supported yet (story redeclared)
const B = { args: data };
const C = { args: data };
export { B, C as D };
+
❯ src/codemod/helpers/story-to-csf-factory.test.ts:691:27
|
|
src/codemod/helpers/story-to-csf-factory.test.ts > stories codemod > typescript > should support non-conventional formats:
code/lib/cli-storybook/src/codemod/helpers/story-to-csf-factory.test.ts#L647
Error: Snapshot `stories codemod > typescript > should support non-conventional formats 1` mismatched
- Expected
+ Received
- import preview from '#.storybook/preview';
+ import { StoryObj as CSF3, Meta } from '@storybook/react';
import { A as Component } from './Button';
import { ComponentProps } from './Component';
import * as Stories from './Other.stories';
import someData from './fixtures';
- const meta = preview.meta({
+ export default {
title: 'Component',
component: Component,
-
// not supported yet (story coming from another file)
args: Stories.A.args,
- });
+ };
-
const data = {};
- export const A = meta.story(() => {});
+ export const A: StoryObj = () => {};
- export const B = meta.story(() => {});
+ export function B() {}
- export const C = meta.story(() => <Component />);
+ export const C = () => <Component />;
- export const D = C.input;
+ export const D = C;
// not supported yet (story redeclared)
- const E = { ...A.input, args: data } satisfies CSF3<ComponentProps>;
+ const E = { ...A, args: data } satisfies CSF3<ComponentProps>;
const F = { args: data };
export { E, F as G };
❯ src/codemod/helpers/story-to-csf-factory.test.ts:647:27
|
|
src/codemod/helpers/story-to-csf-factory.test.ts > stories codemod > javascript > should support non-conventional formats (INCOMPLETE):
code/lib/cli-storybook/src/codemod/helpers/story-to-csf-factory.test.ts#L320
Error: Snapshot `stories codemod > javascript > should support non-conventional formats (INCOMPLETE) 1` mismatched
- Expected
+ Received
- import preview from '#.storybook/preview';
-
import { A as Component } from './Button';
import * as Stories from './Other.stories';
import someData from './fixtures';
- const meta = preview.meta({
+ export default {
component: Component,
-
// not supported yet (story coming from another file)
args: Stories.A.args,
- });
+ };
-
const data = {};
- export const A = meta.story(() => {});
+ export const A = () => {};
- export const B = meta.story(() => {});
+ export function B() {}
// not supported yet (story redeclared)
- const C = { ...A.input, args: data };
+ const C = { ...A, args: data };
const D = { args: data };
export { C, D as E };
❯ src/codemod/helpers/story-to-csf-factory.test.ts:320:27
|
|
src/codemod/helpers/story-to-csf-factory.test.ts > stories codemod > javascript > does not migrate reused properties from disallowed list:
code/lib/cli-storybook/src/codemod/helpers/story-to-csf-factory.test.ts#L271
Error: Snapshot `stories codemod > javascript > does not migrate reused properties from disallowed list 1` mismatched
- Expected
+ Received
- import preview from '#.storybook/preview';
-
- const meta = preview.meta({
- title: 'Component',
- });
+ export default { title: 'Component' };
-
- export const A = meta.story();
+ export const A = {};
- export const B = meta.story({
+ export const B = {
play: async () => {
await A.play();
},
- });
+ };
export const C = A.run;
export const D = A.extends({});
❯ src/codemod/helpers/story-to-csf-factory.test.ts:271:7
|