Check all arguments sent to action() for event objects#132
Merged
arunoda merged 2 commits intostorybookjs:masterfrom Apr 21, 2016
akblurton:event-serialization
Merged
Check all arguments sent to action() for event objects#132arunoda merged 2 commits intostorybookjs:masterfrom akblurton:event-serialization
arunoda merged 2 commits intostorybookjs:masterfrom
akblurton:event-serialization
Conversation
Member
|
This is great. |
Contributor
Author
|
No problem, I've duplicated and modified the existing test case for event serialization. |
Member
|
Okay. Looks great. |
Member
|
Published as: |
wyattdanger
pushed a commit
to wyattdanger/react-storybook
that referenced
this pull request
Apr 26, 2016
* Check for events passed to action() in all arguments, rather than just the first * Add test case for new event serialization
ndelangen
pushed a commit
that referenced
this pull request
Apr 5, 2017
Add option to use storybook with more than one user
ghost
mentioned this pull request
This was referenced Feb 1, 2020
|
View your CI Pipeline Execution ↗ for commit e2ed55e
☁️ Nx Cloud last updated this comment at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, only the first argument sent to an action() is checked to see if it is an event (which cannot be serialized without creating an error). If an event is passed to the callback in any other position, i.e. if the component does some processing on the event first, it will still attempt serialization and fail.
This is a quick fix to map over all arguments and replace any event objects found.