Core: Check webpack version #14256
Merged
Core: Check webpack version #14256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmeasday
approved these changes
Mar 17, 2021
Member
tmeasday
left a comment
tmeasday
left a comment
There was a problem hiding this comment.
LGTM although I think you could type the object a tiny bit ({version?: string } maybe?) and cast to it
This was referenced Mar 17, 2021
Merged
Merged
3 tasks
This was referenced Mar 17, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #14252
What I did
Added version checks:
How to test
I manually set the wrong version using yarn resolutions in a test project