Skip to content

Show first story on OnDeviceUI startup#1510

Merged
shilman merged 4 commits intorelease/3.2from
1492-on-device-startup
Jul 23, 2017
Merged

Show first story on OnDeviceUI startup#1510
shilman merged 4 commits intorelease/3.2from
1492-on-device-startup

Conversation

@shilman
Copy link
Copy Markdown
Member

@shilman shilman commented Jul 22, 2017 •
edited
Loading

Issue: #1492

What I did

  • Fix startup message
  • Fix required URL prop-type error (I think this is not really a fix @matt-oakes @ajwhite ?)
  • Automatically jump to first story when OnDeviceUI starts

How to test

yarn && yarn bootstrap && yarn bootstrap:react-native-vanilla
cd examples/react-native-vanilla
yarn storybook
open http://localhost:7007
./node_modules/.bin/react-native run-ios

You should see the first story Welcome > to Storybook selected in the on-device UI.

shilman added 3 commits July 22, 2017 11:20
@shilman
Fix RN preview welcome instructions
a0a8ab3
@shilman
Reset storybook on startup?
0f8755c 
@matt-oakes I’m not sure why I need to do this but I get a “URL
required” prop-types error unless I force `resetStorybook` in
`react-native-vanilla` example
@shilman
Show first story on OnDeviceUI startup
8f8f55e
@shilman shilman merged commit dfaaa09 into release/3.2 Jul 23, 2017
@Hypnosphi Hypnosphi deleted the 1492-on-device-startup branch August 17, 2017 22:28
This was referenced Jan 12, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndelangen ndelangen ndelangen approved these changes

@tmeasday tmeasday Awaiting requested review from tmeasday

@atticoos atticoos Awaiting requested review from atticoos

Assignees

No one assigned

Labels

feature request react-native

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shilman @ndelangen