Fix react native example and bootstrapping#1514
Merged
Conversation
shilman
changed the title
ndelangen
approved these changes
Jul 24, 2017
| // this.channel should get overwritten by setChannel if package versions are | ||
| // correct and AddonStore is a proper singleton. If not, throw an error. | ||
| this.channel = { on: channelError, emit: channelError }; | ||
| this.channel = null; |
Member
Author
There was a problem hiding this comment.
It wasn't good! It wasted multiple hours of my time! 😭
Codecov Report
@@ Coverage Diff @@
## master #1514 +/- ##
==========================================
+ Coverage 14.6% 14.61% +<.01%
==========================================
Files 202 202
Lines 4655 4653 -2
Branches 521 522 +1
==========================================
Hits 680 680
+ Misses 3513 3509 -4
- Partials 462 464 +2
Continue to review full report at Codecov.
|
tmeasday
approved these changes
Jul 25, 2017
Member
tmeasday
left a comment
tmeasday
left a comment
There was a problem hiding this comment.
Not sure about the bootstrapping bit, but good with removing the check.
Member
|
An alternative approach: #1515 |
This was referenced Jan 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #1509
What I did
Addresses issues raised in #1509:
How to test