FIX hoist-internals: remove existing folder/link before linking#1516
Merged
FIX hoist-internals: remove existing folder/link before linking#1516
Conversation
This was referenced Jan 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: -sometimes known packages are not linked by lerna, because it feels like the semver doesn't match -
This can happen when the version is something like
3.2.0-alpha.8which is strictly speaking not valid semver.We always want our packages linked, no matter the semver.
What I did
This fixes it, by always linking.
This resolves the problem where
hoist-internalswould fail to symlink a folder, because it the target was a folder instead of a symlink.The way I fixed it was by removing the target before creating the symlink.
How to test