Fix bad merge that removed react-treebeard dep from lib/ui#1531
Merged
shilman merged 1 commit intorelease/3.2from Jul 27, 2017
Merged
Fix bad merge that removed react-treebeard dep from lib/ui#1531shilman merged 1 commit intorelease/3.2from
shilman merged 1 commit intorelease/3.2from
Conversation
ndelangen
approved these changes
Jul 27, 2017
This was referenced Jan 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: N/A
What I did
Fix a bad merge, but submitting it as a PR because there are still some version issues and also I'm not comfortable with the current state on my machine. Somehow the treebeard stuff is still working on my machine in
cra-kitchen-sinkeven when I do a clean install and I don't understand why.What I need
@ndelangen can you review and also fix these version issues?
I propose we fix up the versions, do one last alpha release, and test it out before we pull the trigger on the 3.2 release.