Skip to content

UI: update font family #1560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hypnosphi merged 2 commits into from
Aug 1, 2017
Merged

UI: update font family #1560

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb2618d
UI: update font family
Hypnosphi Jul 31, 2017
bdbae36
Merge branch 'master' into update-fonts
danielduan Aug 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/ui/src/modules/ui/components/theme.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
export const baseFonts = {
fontFamily: `
-apple-system, ".SFNSText-Regular", "San Francisco", "Roboto",
"Segoe UI", "Helvetica Neue", "Lucida Grande", sans-serif
-apple-system, BlinkMacSystemFont, "Segoe UI", "Roboto", "Oxygen", "Ubuntu",
"Cantarell", "Fira Sans", "Droid Sans", "Arial", sans-serif
Copy link
Copy Markdown
Member

@danielduan danielduan Jul 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Helvetica Neue is still necessary for OS X 10.11 and below when not in Chrome:
https://bitsofco.de/the-new-system-font-stack/

Copy link
Copy Markdown
Member Author

@Hypnosphi Hypnosphi Jul 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't Arial be available there?

Copy link
Copy Markdown
Member

@danielduan danielduan Jul 31, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it is. I think it's included to conform to the system's original styles and Arial is an unfamiliar and clunky looking font to Mac users.

Copy link
Copy Markdown
Member Author

@Hypnosphi Hypnosphi Aug 1, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well if the alternative is to have a font that jumps when going from normal to bold (and we have a menu in which it happens all the time), the unfamiliarity is a lesser evil

Copy link
Copy Markdown
Member

@danielduan danielduan Aug 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm fair enough.

`,
color: '#444',
};