Addon Info: Remove broken prop type sort (keep defined order)#1711
Merged
danielduan merged 2 commits intostorybookjs:masterfrom Aug 22, 2017
mordentware:addon-info-remove-broken-prop-sort
Merged
Addon Info: Remove broken prop type sort (keep defined order)#1711danielduan merged 2 commits intostorybookjs:masterfrom mordentware:addon-info-remove-broken-prop-sort
danielduan merged 2 commits intostorybookjs:masterfrom
mordentware:addon-info-remove-broken-prop-sort
Conversation
Contributor
Author
|
I really don't feel like the failing tests are anything to do with my change. Anyone care to comment on that? |
danielduan
approved these changes
Aug 22, 2017
Member
|
looks good, thanks! |
Member
|
@mordentware @danielduan someone of you had to update storyshots ( |
Closed
Closed
This was referenced Jan 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: Prop Types sort is fundamentally broken. Following conversation in Discord, resolution was to remove sort (rather than add fixed name-based sort).
What I did
How to test
Put prop types for a component in a given order. They will display in that order.
Is this testable with jest or storyshots?
Yes (not currently tested for; tests for the Info addon are minimal and need fleshing out)
Does this need a new example in the kitchen sink apps?
No
Does this need an update to the documentation?
No