Controls: Improve the accessibility of the object control #31581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entire document and pass it to the fields
Sidnioulz
changed the title
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
LGTM
4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
8 tasks
|
View your CI Pipeline Execution ↗ for commit b82f413.
☁️ Nx Cloud last updated this comment at |
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 49 | 49 | 0 |
| Self size | 31.87 MB | 31.85 MB | 🎉 -16 KB 🎉 |
| Dependency size | 17.41 MB | 17.41 MB | 0 B |
| Bundle Size Analyzer | Link | Link |
sb
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 50 | 50 | 0 |
| Self size | 1 KB | 1 KB | 🎉 -20 B 🎉 |
| Dependency size | 49.27 MB | 49.26 MB | 🎉 -16 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/cli
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 216 | 216 | 0 |
| Self size | 582 KB | 582 KB | 🎉 -20 B 🎉 |
| Dependency size | 95.13 MB | 95.12 MB | 🎉 -16 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/codemod
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 185 | 185 | 0 |
| Self size | 31 KB | 31 KB | 0 B |
| Dependency size | 79.26 MB | 79.25 MB | 🎉 -16 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
ghengeveld
approved these changes
Jun 25, 2025
github-project-automation
bot
moved this from Empathy Queue (prioritized)
to Done
in Core Team Projects
71 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves #24150 but does not close it. The PR improves accessibility. Before the PR, it was impossible to edit JSON controls with the keyboard. Now, it's very difficult but no longer impossible.
This branch is a rebase of #24580 that has suffered significant drift. Note that I am not the original PR author and the original PR had been approved by @JReinhold. I'm opening this new PR to provide a clean CI status and to free up @fscgustavo who wrote the original PR.
I'll edit the original issue with additional steps to bring it to completion.
Caution
I recommend squashing this PR, the commit history misuses semantic commits and could lead future maintainers to think these commits aren't supposed to make user-facing changes.
Greptile Summary
Improves keyboard accessibility for JSON controls in Storybook by introducing a new accessible accordion component and enhancing keyboard navigation patterns.
JsonNodeAccordion.tsxwith proper ARIA attributes and keyboard support for JSON tree editingJsonNodes.tsxin favor of component-level keyboard handlersObject.tsxfor better screen reader supporteditButtonElementprop fromJsonTreecomponent as part of accessibility improvements