Skip to content

Onboarding: Intent survey #31944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Jul 9, 2025
Merged

Onboarding: Intent survey #31944

merged 22 commits into from
Jul 9, 2025

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Jul 3, 2025

Closes #31850

What I did

Added a survey as the last step of onboarding (after the guided tour):

Screenshot 2025-07-03 at 12 51 14

Results are sent as telemetry event data.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

Adds an intent survey as the final step of the onboarding process to collect user feedback about how they plan to use Storybook. Results are sent as telemetry data.

  • Added new IntentSurvey component in code/addons/onboarding/src/features/IntentSurvey/IntentSurvey.tsx with modal form UI
  • Reorganized form components under code/core/src/components/components/Form/ with new Field, Radio, Checkbox implementations
  • Changed Modal's Container overflow from 'hidden' to 'auto' in code/core/src/components/components/Modal/Modal.styled.tsx to support scrolling
  • Added new telemetry event types 'addon-onboarding' and 'onboarding-survey' in code/core/src/telemetry/types.ts
  • Modified onboarding flow to add '6:IntentSurvey' step before final completion in code/addons/onboarding/src/constants.ts

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

23 files reviewed, 13 comments
Edit PR Review Bot Settings | Greptile

Copy link

nx-cloud bot commented Jul 3, 2025

View your CI Pipeline Execution ↗ for commit a207776

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 17s View ↗

☁️ Nx Cloud last updated this comment at 2025-07-08 22:03:20 UTC

@storybook-pr-benchmarking
Copy link

storybook-pr-benchmarking bot commented Jul 4, 2025

Package Benchmarks

Commit: a207776, ran on 8 July 2025 at 21:47:48 UTC

The following packages have significant changes to their size or dependencies:

storybook

Before After Difference
Dependency count 51 51 0
Self size 31.75 MB 31.76 MB 🚨 +14 KB 🚨
Dependency size 17.43 MB 17.43 MB 🚨 +5 KB 🚨
Bundle Size Analyzer Link Link

sb

Before After Difference
Dependency count 52 52 0
Self size 1 KB 1 KB 0 B
Dependency size 49.18 MB 49.20 MB 🚨 +19 KB 🚨
Bundle Size Analyzer Link Link

@storybook/cli

Before After Difference
Dependency count 217 217 0
Self size 582 KB 582 KB 0 B
Dependency size 94.81 MB 93.67 MB 🎉 -1.14 MB 🎉
Bundle Size Analyzer Link Link

@storybook/codemod

Before After Difference
Dependency count 186 186 0
Self size 31 KB 31 KB 0 B
Dependency size 78.91 MB 77.77 MB 🎉 -1.14 MB 🎉
Bundle Size Analyzer Link Link

@ghengeveld ghengeveld requested a review from shilman July 4, 2025 14:58
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!!! 😍

How would you feel about patching this back to 9.0.x?

@shilman shilman changed the title Addon Onboarding: Intent survey Onboarding: Intent survey Jul 5, 2025
@shilman shilman added maintenance User-facing maintenance tasks and removed feature request labels Jul 5, 2025
@ghengeveld ghengeveld added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jul 7, 2025
@ghengeveld ghengeveld force-pushed the onboarding-intent-survey branch from f6158a1 to 54a4322 Compare July 8, 2025 14:02
@ghengeveld ghengeveld merged commit 9e65cc0 into next Jul 9, 2025
55 checks passed
@ghengeveld ghengeveld deleted the onboarding-intent-survey branch July 9, 2025 06:17
ghengeveld added a commit that referenced this pull request Jul 15, 2025
Onboarding: Intent survey
(cherry picked from commit 9e65cc0)
ghengeveld added a commit that referenced this pull request Jul 15, 2025
Onboarding: Intent survey
(cherry picked from commit 9e65cc0)
ghengeveld added a commit that referenced this pull request Jul 15, 2025
Onboarding: Intent survey
(cherry picked from commit 9e65cc0)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: onboarding ci:normal maintenance User-facing maintenance tasks patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request]: Onboarding Intent Survey
4 participants