Add parameter typings for addon-pseudo-state #32384
Open
+69
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
mrginglymus
force-pushed
the
pseudo-params
branch
from
bf82332 to
fb50aaf
Compare
|
View your CI Pipeline Execution ↗ for commit 3b70a9b
☁️ Nx Cloud last updated this comment at |
Sidnioulz
added
ci:normal
addon: pseudo-states
maintenance
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 186 | 186 | 0 |
| Self size | 68 KB | 68 KB | 0 B |
| Dependency size | 31.39 MB | 31.47 MB | 🚨 +80 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
storybook
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 48 | 48 | 0 |
| Self size | 30.74 MB | 30.62 MB | 🎉 -117 KB 🎉 |
| Dependency size | 17.61 MB | 17.61 MB | 🚨 +3 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/angular
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 186 | 186 | 0 |
| Self size | 134 KB | 134 KB | 0 B |
| Dependency size | 29.62 MB | 29.69 MB | 🚨 +77 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/ember
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 191 | 191 | 0 |
| Self size | 17 KB | 17 KB | 0 B |
| Dependency size | 28.11 MB | 28.19 MB | 🚨 +80 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/nextjs
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 529 | 529 | 0 |
| Self size | 928 KB | 928 KB | 0 B |
| Dependency size | 58.29 MB | 58.44 MB | 🚨 +157 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/nextjs-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 130 | 130 | 0 |
| Self size | 4.00 MB | 4.00 MB | 🎉 -9 B 🎉 |
| Dependency size | 21.39 MB | 21.70 MB | 🚨 +310 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/react-native-web-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 163 | 163 | 0 |
| Self size | 31 KB | 31 KB | 🎉 -24 B 🎉 |
| Dependency size | 22.78 MB | 23.09 MB | 🚨 +310 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/react-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 120 | 120 | 0 |
| Self size | 36 KB | 36 KB | 0 B |
| Dependency size | 19.33 MB | 19.64 MB | 🚨 +310 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/react-webpack5
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 272 | 272 | 0 |
| Self size | 25 KB | 25 KB | 🎉 -18 B 🎉 |
| Dependency size | 43.03 MB | 43.18 MB | 🚨 +157 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/server-webpack5
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 198 | 198 | 0 |
| Self size | 17 KB | 17 KB | 0 B |
| Dependency size | 32.64 MB | 32.72 MB | 🚨 +80 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/cli
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 204 | 219 | 🚨 +15 🚨 |
| Self size | 879 KB | 879 KB | 🎉 -90 B 🎉 |
| Dependency size | 81.71 MB | 81.90 MB | 🚨 +181 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/codemod
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 173 | 188 | 🚨 +15 🚨 |
| Self size | 35 KB | 35 KB | 🎉 -54 B 🎉 |
| Dependency size | 76.79 MB | 76.97 MB | 🚨 +181 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
create-storybook
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 49 | 49 | 0 |
| Self size | 1.52 MB | 1.52 MB | 0 B |
| Dependency size | 48.35 MB | 48.24 MB | 🎉 -114 KB 🎉 |
| Bundle Size Analyzer | node | node |
eslint-plugin-storybook
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 35 | 35 | 0 |
| Self size | 139 KB | 139 KB | 🚨 +6 B 🚨 |
| Dependency size | 3.41 MB | 3.48 MB | 🚨 +77 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/preset-create-react-app
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 68 | 68 | 0 |
| Self size | 26 KB | 26 KB | 0 B |
| Dependency size | 5.97 MB | 6.05 MB | 🚨 +77 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/preset-react-webpack
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 170 | 170 | 0 |
| Self size | 26 KB | 26 KB | 0 B |
| Dependency size | 30.55 MB | 30.63 MB | 🚨 +80 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Export types for adodn-pseudo parameters and add to preview definition for typing in csf4.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
Updated On: 2025-09-03 10:31:08 UTC
This PR enhances TypeScript support for the
addon-pseudo-statesby adding comprehensive parameter typings for CSF4 (Component Story Format 4) integration. The changes reorganize type definitions by moving thePseudoStatetype fromconstants.tsto a new dedicatedtypes.tsfile, which now contains a complete type system includingPseudoStateConfig,PseudoParameter,PseudoParameters, andPseudoTypesinterfaces.The new type system enables proper IntelliSense and type checking when configuring pseudo-state parameters in stories. The
PseudoTypesinterface is specifically designed to integrate with Storybook's addon system throughdefinePreviewAddon<PseudoTypes>(), providing type safety for thepseudoparameter that controls pseudo-state behavior like hover, focus, and other CSS pseudo-states.The refactoring consolidates all type definitions in
types.ts, updates imports inwithPseudoState.tsto use the centralized types, and modifiesindex.tsto export the new types while applying generic typing to the preview addon definition. This follows Storybook's modern addon patterns and improves the developer experience without changing any runtime behavior.PR Description Notes:
Confidence score: 5/5