UI: Add test numbers to sidebar #32418
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| @@ -575,6 +575,7 @@ export const init: ModuleFn<SubAPI, SubState> = ({ | |||
| // The story index we receive on fetchStoryIndex is not, but all the prepared fields are optional | |||
| // so we can cast one to the other easily enough | |||
| setIndex: async (input) => { | |||
| console.log('setIndex', input); | |||
There was a problem hiding this comment.
style: Debug logging should be removed before merging to production
Suggested change
| console.log('setIndex', input); | |
| // console.log('setIndex', input); |
| @@ -590,6 +591,7 @@ export const init: ModuleFn<SubAPI, SubState> = ({ | |||
| allStatuses, | |||
| }); | |||
|
|
|||
| console.log({ oldHash, filteredIndex: addPreparedStories(newFilteredHash, oldFilteredHash) }); | |||
There was a problem hiding this comment.
style: Debug logging should be removed before merging to production
Suggested change
| console.log({ oldHash, filteredIndex: addPreparedStories(newFilteredHash, oldFilteredHash) }); | |
| // console.log({ oldHash, filteredIndex: addPreparedStories(newFilteredHash, oldFilteredHash) }); |
|
View your CI Pipeline Execution ↗ for commit 32650c3
☁️ Nx Cloud last updated this comment at |
|
Will park this PR until further discussions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
What I did
Now stories with tests will have a numbered badge
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-32418-sha-6377e85a. Try it out in a new sandbox by runningnpx [email protected] sandboxor in an existing project withnpx [email protected] upgrade.More information
0.0.0-pr-32418-sha-6377e85ayann/add-test-numbers6377e85a1757064700)To request a new release of this pull request, mention the
@storybookjs/coreteam.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=32418Greptile Summary
Updated On: 2025-09-05 09:32:23 UTC
This PR adds visual test count indicators to the Storybook sidebar as numbered badges on story nodes. The implementation introduces a new
numberBadgeprop to theStoryNodecomponent that displays the count of tests associated with each story. The badge shows numbers 1-9 directly and "9+" for counts above 9, with styling that adapts to selection states.The changes span several key areas:
TreeNode.tsxto addIconWithBadgeandNumberBadgestyled components, along with a newnumberBadgeprop forStoryNodeTreeNode.stories.tsxto demonstrate different badge states (no tests, some tests, many tests)mockdata.tsto include multiple test entries for proper testing of the badge functionalityfindAllLeafStoryIdsfunction instories.tsto reorder conditional logic for better handling of nodes with childrenThis feature integrates with Storybook's existing navigation tree structure and supports the broader initiative to add test syntax support in CSF (Component Story Format). The badges provide users with immediate visual feedback about test coverage and help identify which stories have associated tests.
PR Description Notes:
Confidence score: 3/5
code/core/src/manager-api/modules/stories.tswhich contains debug logging that should be removed