Skip to content

Instrumenter: Fix userEvent.type performance regression #32439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 12, 2025
+6 −2
Merged

Instrumenter: Fix userEvent.type performance regression #32439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
33dd46c
fix: optimize userEvent.type performance by filtering eventWrapper fr…
ndelangen Sep 11, 2025
2e4237e
Merge branch 'next' into norbert/fix-type-event-slowdown
ndelangen Sep 11, 2025
58fa69b
Merge branch 'next' into norbert/fix-type-event-slowdown
ndelangen Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion code/core/src/test/preview.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,10 @@ const enhanceContext: LoaderFunction = async (context) => {
if (clipboard) {
context.userEvent = instrument(
{ userEvent: uninstrumentedUserEvent.setup() },
{ intercept: true }
{
intercept: true,
getKeys: (obj) => Object.keys(obj).filter((key) => key !== 'eventWrapper'),
}
).userEvent;

// Restore original clipboard, which was replaced with a stub by userEvent.setup()
Expand Down
3 changes: 2 additions & 1 deletion code/core/src/test/testing-library.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ type TestingLibraryDom = typeof domTestingLibrary;
const testingLibrary = instrument(
{ ...domTestingLibrary },
{
getKeys: (obj) => Object.keys(obj).filter((key) => key !== 'eventWrapper'),
intercept: (method, path) =>
path[0] === 'fireEvent' || method.startsWith('find') || method.startsWith('waitFor'),
}
Expand Down Expand Up @@ -118,5 +119,5 @@ export const uninstrumentedUserEvent = _userEvent.userEvent;

export const { userEvent }: { userEvent: UserEvent['userEvent'] } = instrument(
{ userEvent: _userEvent.userEvent },
{ intercept: true }
{ intercept: true, getKeys: (obj) => Object.keys(obj).filter((key) => key !== 'eventWrapper') }
);