-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Build: Update nx to 22 and invalidate cache when scripts change #33076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a `--fix` option to the script for automatically correcting parallelism counts in workflow files. - Implemented logic to read and update parallelism values in the corresponding YAML files while preserving formatting and comments. - Enhanced error messages to guide users on regenerating the main config file after fixes.
Co-authored-by: Valentin Palkovic <[email protected]>
…orybook into yann/reduce-flake-stories
…com:storybookjs/storybook into yann/do-not-remove-used-types-csf-factories
- Replace Dockerfile-based Danger build with ghcr.io/danger/danger-js:13.0.5 - Dangerfile cleaned up (ESM, no execSync/lodash)
This reverts commit 709bbf1.
This reverts commit e36c039.
Build: Improve snapshots for some stories
Docs: Fix grammar in the monorepo readme
Docs: Improve error statement on empty stories configuration
Vue: Cleanup comments in Vue templates
…ories Docs: Fix broken links in Jest portable stories
Build: Remove local Danger Docker build and use ghcr.io runtime
…pes-csf-factories CLI: In csf-factories codemod only remove types which are unused
…d streamline label checks
…xtension and add new Dangerfile script for PR label checks
…xtension and add new Dangerfile script for PR label validation and title checks
…on path resolution
…tension and add new Dangerfile script for PR label validation and title checks
Danger: Fix the config file
8 tasks
Copilot
AI
changed the title
[WIP] Update nx to version 22 and invalidate cache on script changes
Build: Update nx to 22 and invalidate cache when scripts change
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
What I did
Updated nx tooling to v22 and added cache invalidation for script changes. The upgrade removes deprecated
useLegacyCacheoption and adds runtime script tracking to bust cache when files inscripts/directory change.Changes:
nx,@nx/vite,@nx/workspacefrom 20.8.2 to 22.0.3useLegacyCache: falsefrom nx.json (no longer supported in v22)autoExit: trueto tui config for better CI automationsharedGlobals:nextbranch (regeneratedyarn.lock)Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
No manual testing required. Dependency upgrade with configuration changes that will be validated by existing CI workflows.
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.