Fix error in favicon customization documentation #1977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because I tested this example to replace the favicon, and I've got an error.
```bash
yarn run v1.22.19
$ strapi build
⠋ Building build context
[INFO] Including the following ENV variables as part of the JS bundle:
- ADMIN_PATH
- STRAPI_ADMIN_BACKEND_URL
- STRAPI_TELEMETRY_DISABLED
✔ Building build context (73ms)
⠋ Building admin panel
⠴ Building admin panel[ERROR] Module not found: Error: Can't resolve './extensions/favicon.png' in '/var/www/strapi/src/admin'
✖ Building admin panel
[ERROR] There seems to be an unexpected error, try again with --debug for more information
error Command failed with exit code 1.
```
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
thomasbnt
changed the title
./extensions./extensions
pwizla
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
Thanks, @thomasbnt!
It's approved, merged, should be live on docs.strapi.io in a few minutes, and will be mentioned in the next weekly snapshot release.
pwizla
changed the title
./extensions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because I tested this example to replace the favicon, and I've got an error.
yarn run v1.22.19 $ strapi build ⠋ Building build context [INFO] Including the following ENV variables as part of the JS bundle: - ADMIN_PATH - STRAPI_ADMIN_BACKEND_URL - STRAPI_TELEMETRY_DISABLED ✔ Building build context (73ms) ⠋ Building admin panel ⠴ Building admin panel[ERROR] Module not found: Error: Can't resolve './extensions/favicon.png' in '/var/www/strapi/src/admin' ✖ Building admin panel [ERROR] There seems to be an unexpected error, try again with --debug for more information error Command failed with exit code 1.What does it do?
I changed the example code at https://docs.strapi.io/dev-docs/admin-panel-customization#favicon
Why is it needed?
Just adding a dot to
../extensions