-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
fix: transfer command with proxy support #23657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dhoko
wants to merge
3
commits into
strapi:develop
Choose a base branch
from
dhoko:fix/transfer-command
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
220e230
to
ae85be3
Compare
0a7c9c7
to
5f40f32
Compare
8e9fe89
to
24d6037
Compare
7735ff1
to
f45d930
Compare
f45d930
to
8c6ad6b
Compare
8c6ad6b
to
2df6a32
Compare
2df6a32
to
3f4a9dc
Compare
log errors when the transfer task faill ex error we will be able to see when we run the transfer task: console.error(e) ``` ProviderTransferError at WebSocket.<anonymous> (/builds/web/cms/node_modules/ @strapi/data-transfer/dist/strapi/providers/utils.js:158:20) at Object.onceWrapper (node:events:639:26) at WebSocket.emit (node:events:524:28) at WebSocket.emit (node:domain:489:12) at emitErrorAndClose (/builds/web/cms/node_modules/ws/lib/ websocket.js:1035:13) at ClientRequest.<anonymous> (/builds/web/cms/node_modules/ ws/lib/websocket.js:880:5) at ClientRequest.emit (node:events:524:28) at ClientRequest.emit (node:domain:489:12) at emitErrorEvent (node:_http_client:101:11) at TLSSocket.socketErrorListener (node:_http_client:504:5) { origin: 'provider', severity: 'fatal', details: { step: 'transfer', details: { details: [Object] } } } ``` console.error(e.details.details) ``` { details: { error: '' } } ```` And the default error message we used to see: `Transfer process failed.`
3f4a9dc
to
c658e34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋
What does it do?
The current version of the command is unable to run inside a CI env with a proxy.
ex:
That's it, nothing else.
Why is it needed?
So we can execute the command inside an env with a proxy, ex a CI job.
How to test it?
Set a proxy, run the transfer it fails. Fixed via
sed
inside my CI to validate everything.I also added to my env
GLOBAL_AGENT_ENVIRONMENT_VARIABLE_NAMESPACE: ''
cf https://www.npmjs.com/package/global-agent#what-is-the-reason-global-agentbootstrap-does-not-use-http_proxyNow when it fails we will hav a few more informations:
To validate it, I have a job inside my CI to execute the command. Before calling it I added:
Related issue(s)/PR(s)
#22755
strapi/documentation#2514