Skip to content

libblkid-rs-sys: Increase bindgen dependency lower bound to 0.71.0 #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2025
Merged

libblkid-rs-sys: Increase bindgen dependency lower bound to 0.71.0 #198

merged 1 commit into from
May 2, 2025

Conversation

mulkieran
Copy link
Member

@mulkieran mulkieran commented Apr 24, 2025 •
edited
Loading

@mulkieran mulkieran self-assigned this Apr 24, 2025
@mulkieran mulkieran moved this to Pending in 2025April Apr 24, 2025
@mulkieran mulkieran force-pushed the bindgen-0.71.0 branch 2 times, most recently from 035576f to 04e1d69 Compare April 24, 2025 21:06
@mulkieran mulkieran moved this from Pending to In Progress in 2025April Apr 24, 2025
@mulkieran
Copy link
Member Author

mulkieran commented Apr 24, 2025 •
edited
Loading

Using bindgen 0.71.0 causes emitting of code that Rust 1.77.0 does not tolerate. Here is a related bindgen issue: rust-lang/rust-bindgen#2901 . In theory, specifying Edition 2021 generation should fix our build failure, but that doesn't seem to work, unfortunately.

@mulkieran mulkieran force-pushed the bindgen-0.71.0 branch 4 times, most recently from 3ea92a3 to fce98b3 Compare April 25, 2025 00:46
@mulkieran mulkieran moved this from In Progress to Pending in 2025April Apr 25, 2025
@mulkieran mulkieran marked this pull request as ready for review April 25, 2025 14:25
@mulkieran mulkieran force-pushed the bindgen-0.71.0 branch 4 times, most recently from 095e2cc to 0d21b84 Compare May 2, 2025 13:35
@mulkieran
libblkid-rs-sys: Increase bindgen dependency lower bound to 0.71.0
0d21b84 
Use rust-version in Cargo.toml as rust target.

Signed-off-by: mulhern <[email protected]>
@mulkieran mulkieran requested a review from jbaublitz May 2, 2025 15:33
@mulkieran mulkieran moved this from Pending to In Review in 2025April May 2, 2025
@mulkieran mulkieran merged commit 43c9582 into stratis-storage:master May 2, 2025
14 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in 2025April May 2, 2025
@mulkieran mulkieran deleted the bindgen-0.71.0 branch May 2, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbaublitz jbaublitz jbaublitz approved these changes

Assignees

@mulkieran mulkieran

Labels
None yet
Projects
No open projects
2025April
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mulkieran @jbaublitz