Skip to content

Migrate CombinePolygonSystemTx #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 26 commits into from
Closed

Conversation

Rampex1
Copy link

@Rampex1 Rampex1 commented Jun 27, 2025

No description provided.

Rampex1 and others added 26 commits June 20, 2025 10:21
* consensus,miner: allow mining in case of no peers if DevFakeAuthor is enabled

* miner: explicitly assert consensus engine type

* params: version bump to v2.1.0

* added Bhilai and Prague block for mainnet (ethereum#1581)

* params: version bump to v2.1.1

---------

Co-authored-by: Raneet Debnath <[email protected]>
Co-authored-by: Raneet Debnath <[email protected]>
Co-authored-by: Pratik Patil <[email protected]>
* CI: Dockerfile for bor binary

* MTN: Modified workflow for bor

* Workflow fix + vulnerability

* Newer go version to fix vulnerabilities

* Dockerfile fix
When checkpoint verifier inserts canonical chain after rewind, the fork choice
logic in writeBlockAndSetHead() may determine that no reorg is needed, causing
blocks to be inserted with SideStatTy instead of CanonStatTy. This prevents
writeHeadBlock() from being called, leaving canonical hash mappings outdated.

The issue manifests as:
- "Successfully inserted canonical chain" log appears
- GetBlockByNumber() still returns old block hash
- Fork detection triggers false positives for whitelisted blocks
- Milestone reorg protection fails

Fix by explicitly calling SetCanonical() after InsertChain() to force
canonical status and ensure proper canonical hash mapping updates.
@sduchesneau sduchesneau force-pushed the release/polygon-2.x-fh3.0 branch from ed6e858 to f5bceb2 Compare June 27, 2025 12:58
@sduchesneau sduchesneau deleted the system-tx-2 branch June 27, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants