Migrate CombinePolygonSystemTx #33
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* consensus,miner: allow mining in case of no peers if DevFakeAuthor is enabled * miner: explicitly assert consensus engine type * params: version bump to v2.1.0 * added Bhilai and Prague block for mainnet (ethereum#1581) * params: version bump to v2.1.1 --------- Co-authored-by: Raneet Debnath <[email protected]> Co-authored-by: Raneet Debnath <[email protected]> Co-authored-by: Pratik Patil <[email protected]>
* CI: Dockerfile for bor binary * MTN: Modified workflow for bor * Workflow fix + vulnerability * Newer go version to fix vulnerabilities * Dockerfile fix
We do not touch this file
When checkpoint verifier inserts canonical chain after rewind, the fork choice logic in writeBlockAndSetHead() may determine that no reorg is needed, causing blocks to be inserted with SideStatTy instead of CanonStatTy. This prevents writeHeadBlock() from being called, leaving canonical hash mappings outdated. The issue manifests as: - "Successfully inserted canonical chain" log appears - GetBlockByNumber() still returns old block hash - Fork detection triggers false positives for whitelisted blocks - Milestone reorg protection fails Fix by explicitly calling SetCanonical() after InsertChain() to force canonical status and ensure proper canonical hash mapping updates.
sduchesneau
force-pushed
the
release/polygon-2.x-fh3.0
branch
from
ed6e858 to
f5bceb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.