Skip to content

Dont truncate sidenav titles #777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 8, 2023
Merged

Dont truncate sidenav titles #777

merged 2 commits into from
Aug 8, 2023

Conversation

sfc-gh-jgarcia
Copy link
Contributor

📚 Context

This PR fixes an issue reported by @MathCatsAnd, where right navigation titles would truncate, something we don't want them to do.

🧠 Description of Changes

  • Removed the truncate Tailwind directive from floatingNav.module.css;
  • Added a bit of padding right to ensure content does not overflow.

Revised:

Screenshot 2023-08-08 at 1 27 09 PM

Current:

Untitled

💥 Impact

Size:

  • Small
  • Not small

🌐 References

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@sfc-gh-jgarcia sfc-gh-jgarcia marked this pull request as ready for review August 8, 2023 16:38
@sfc-gh-dmatthews sfc-gh-dmatthews merged commit 3c9087c into main Aug 8, 2023
@sfc-gh-dmatthews sfc-gh-dmatthews deleted the dont-truncate-sidenav-titles branch August 8, 2023 19:14
@sfc-gh-dmatthews
Copy link
Contributor

Thanks @sfc-gh-jgarcia!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-dmatthews sfc-gh-dmatthews sfc-gh-dmatthews approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-jgarcia @sfc-gh-dmatthews