Skip to content

Conversation

@garyp
Copy link
Collaborator

@garyp garyp commented Jul 31, 2020

This was already in #69 but I've pulled it out into a separate PR because it's also needed for some other PRs currently pending, such as #29.

@garyp garyp requested a review from seanadkinson July 31, 2020 21:34
Copy link
Contributor

@seanadkinson seanadkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing build, but changes LGTM 👍

@garyp garyp force-pushed the fix-java-protoc-task branch from 75016cc to a518f59 Compare August 2, 2020 15:23
@garyp
Copy link
Collaborator Author

garyp commented Aug 2, 2020

Failing build, but changes LGTM 👍

I left out one of the protoc-gen-kotlin options when doing the cherry-pick. Fixed.

@garyp garyp merged commit df58267 into master Aug 2, 2020
@garyp garyp deleted the fix-java-protoc-task branch August 2, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants