Steps and escalators don't show in sidewalk and lit overlays

[rhhsm]

I noticed that some steps and escalators are not showing in the sidewalk and lit overlays, see screenshot

The steps with the missing step count is this one https://www.openstreetmap.org/way/1154777882
Notice that the steps and the escalator next to it appear as voids instead of blue lines or steps, while the paths show. At the other end of the subway platform (that doesn't show either), the steps do show (with or without the tunnel=yes tag), but not at the very end where they are covered by the pedestrian area. There are 2 more steps visible as voids in the pedestrian area. This is how it shows in the sidewalk overlay: in the lit overlay, only steps and escalators that have not been given a lit tag show up as voids instead of red lines. Once they are tagged, they show up in the expected colour.

Expected Behavior
Steps and escalators show up as paths do.

Versions affected
Android 10 and StreetComplete 51.1

[matkoniecz]

Is not highlighted way marked as indoor with indoor=yes? Indoor ways are not highlighted as missing data.

If not indoor, can you link one of marked ways?

https://www.openstreetmap.org/way/1154777882 should not show as missing data as it has valid lit tag - how it shows up now?

[rhhsm]

I found another example, this time with lit overlay. They are 3 parallel escalators, tagged indoor=yes and no lit tag, the middle one is https://www.openstreetmap.org/way/1136011640

I would expect these escalators to show up red, not as if there is no overlay in their location (they do affect the colour of the lit=yes road above). Once I give them a lit tag, they show in the right colour, so why not when they haven't been tagged yet?
I could do some experiments in how these show up, but I don;t want to create changesets for real map objects...

[matkoniecz]

Indoor ways are deliberately excluded from display as missing data as they can be assumed to be lit.

They should be stil tappable.

[rhhsm]

Is not highlighted way marked as indoor with indoor=yes? Indoor ways are not highlighted as missing data.

That makes some sense, although it would still be desirable to distinguish between way that are only lit at night (because they are near windows or skylights) and ones that receive no daylight and need to be permanently lit.

What about steps not showing as blue lines in the sidewalk overlay? I suppose some paths are shown as blue lines that could be pavements and so would lead to choosing "displayed separately". But steps can also be part of pavements (on steep streets) so should sometimes be shown too.

[Helium314]

In the sidewalk overlay this appears to be an oversight. Steps are included in the filter, but never shown unless they are tagged with foot=yes or foot=designated

StreetComplete/app/src/main/java/de/westnordost/streetcomplete/overlays/sidewalk/SidewalkOverlay.kt

Lines 60 to 65 in b2e2505

	private fun getFootwayStyle(element: Element): PolylineStyle {
	val foot = element.tags["foot"] ?: when (element.tags["highway"]) {
	"footway" -> "designated"
	"path" -> "yes"
	else -> null
	}

[westnordost]

Wait, then, feel free to reopen if there is an issue. I only happened upon this ticket by chance

[rhhsm]

In the sidewalk overlay this appears to be an oversight. Steps are included in the filter, but never shown unless they are tagged with foot=yes or foot=designated

I assume steps are seldom tagged with these because they are obviously for pedestrians so no need to tag them as such (we did have some bicycle-designated steps here in Sofia a few years ago, though...). But I don't think, on second thoughts, that it is a problem that they're not displayed in blue in the sidewalk overlay: they're usually short anyway and JawgMaps does display them (though sometimes the location can be out of date, as in my second screenshot).

That the indoor escalators in the second screenshot are not displayed in red is OK, but that they do affect the way the road above (бул. Патриарх Евтимий) is displayed is a minor cosmetic issue. They are selectable, FYI.

[rhhsm]

Might be nice to show ways with footway=sidewalk in a slightly different way (different shade of blue)? Sometimes it's not clear in the field if a path parallel to a road has been tagged as the sidewalk of that road or should be considered as a separate path.

[rhhsm]

...and not to show paths that have tunnel=yes or layer or level with a negative number (underground, so unlikely to be relevant for sidewalks unless the road itself is underground)

[westnordost]

one issue one ticket