Artwork Type

[paulklie]

Closes #2125

I copied most of the implementation from SCEE (Helium314#796) by @vfosnar, with some modifications:

• 1. Migrated to compose
• 2. Resorted elements based on current usage numbers (most popular at the beginning)
• 3. Replaced some images that were not in public domain, or had licensing conflicts.
• 4. Added license information for all pictures
• 5. Added other landart
• 6. Removed landart.

I removed landart for the following reasons:

1. It is quite rare, with less than 0.3% of artwork_type uses.
2. Since landarts are often visible from space, I suspect there is a higher likelihood that they are already mapped by editors using satellite images. Thus an even smaller portion of the remaining unclassified artwork, would be landarts.
3. It has the possibility of being mis-tagged instead of the more popular man_made=geoglyph. Explaining the difference between these two seems beyond scope.
4. A, comparatively large portion of landarts are relations, and are thus not included anyway: While landarts only count as 0.3% of artworks, they count as almost 14% of artwork relations.

[matkoniecz]

I see that it is a draft - what remains to be done? Do you need some help?

[paulklie]

Pretty much just testing, or giving feedback on the selected images.

[mnalis]

Can we also add support for artwork_type=street_art ?

[paulklie]

Can we also add support for artwork_type=street_art ?

I think it could work, I think we would need to title it as "other street art".
Have an idea for picture? Since this category is quite wide

[mnalis]

I think it could work, I think we would need to title it as "other street art". Have an idea for picture? Since this category is quite wide

Yeah, "other street art" sounds good. Perhaps this picture is somewhat representative (can't really be put in other categories):
https://wiki.openstreetmap.org/wiki/File:Painted_hand_water_pump_in_Zagreb,_Most_mladosti.jpg

[paulklie]

https://wiki.openstreetmap.org/wiki/File:Painted_hand_water_pump_in_Zagreb,_Most_mladosti.jpg

I have the feeling this might be hard to recognized when scaled down for smaller screen sizes.

[mnalis]

I have the feeling this might be hard to recognized when scaled down for smaller screen sizes.

Perhaps crop the prominent part of it? Other examples (also on that wiki) that I've had is likely even harder to recognize.

On the other hand, most of street art matches on wikimedia commons are mostly graffiti, mural (with few installation and mosaic), so I've given up searching in that way after few dozen pages... If I know what to search for, there are few more matches similar to that image on commons (see e.g. pimpmypump).

E.g. maybe this one has better contrast?

Or perhaps looking if something else already mapped in OSM as street_art which has picture would suit it better? https://overpass-turbo.eu/s/2fjc

[westnordost]

It is a precedent to include the JPEG source graphics in the /res/graphics directory in this repository. We usually only do this for the (vector) graphics. There is another authors.txt in /app/src/androidMain/res/ which contains all the attribution plus an URL to the source. If there is no good reason to choose a different format here, I'd ask you to do that, for consistency.

[paulklie]

E.g. maybe this one has better contrast?

I tried this one, and I think it works quite well:

[paulklie]

As for the icon, how about an icon like this: https://www.svgrepo.com/svg/359716/art-gallery ?

[westnordost]

Well, like this, I guess. That one is black and white of course.

Or maybe take the icon of some open source (desktop?) paint app? It would be a nice gimmick. GIMP icon although arguably the biggest one is maybe not recognized well enough? Maybe MyPaint: https://github.com/mypaint/mypaint ?

[westnordost]

The other street art icon is very good, because it shows two different kinds of street art.

[westnordost]

This looks to be the current (flat) gimp icon:

https://commons.wikimedia.org/wiki/File:The_GIMP_icon_-_v3.0.svg

I am kind of intrigued....

[westnordost]

It looks like this is done minus the quest icon. Good work!

[westnordost]

(By the way, tried out MyPaint for the first time. It looks like a simpler Krita, i.e. geared towards "real" painting (with an actual canvas pattern as background). Must be pretty fun when you have a pen tablet. But boy is it slow (on my computer).)

Anyway, what do you think about trying the GIMP icon? At least among (FOSS) nerds, it should be well known and would be a nice gimmick. I expect there is a considerable intersection between OSM nerds and FOSS nerds.

[mnalis]

This looks to be the current (flat) gimp icon:
https://commons.wikimedia.org/wiki/File:The_GIMP_icon_-_v3.0.svg

I believe that one might be (in a process of being) trademarked: https://uspto.report/TM/99400787
So perhaps best to contact GNOME foundation about allowable use, if it is to be chosen?

[westnordost]

What does that mean? IANAL. In the linked filing, it says that it is a

Mark For: This trademark registration is intended to cover the categories of downloadable computer software for creating, editing, manipulating, converting, and enhancing digital images.

[mnalis]

TL;DR: it might, or might not, be problematic. Best to clarify with the GNOME foundation.

---

What does that mean?

Trademark means that the usage of logo enjoys certain protections under the law. Anyone may use it freely¹ to refer exactly to GIMP, but to use it to refer to different things (inside protected class) without having permission from trademark owner would be considered violation, AFAIK.

Mark For: This trademark registration is intended to cover the categories of downloadable computer software for creating, editing, manipulating, converting, and enhancing digital images.

Yeah, that quote is why (instead of straight-out claiming StreetComplete may not use it) I merely suggested it would be best to verify with GNOME foundation if we can use it for that purpose.

Because, its registration also says that its Primary International Class includes "surveying [apparatus and instruments]" and "data processing equipment and computers" which StreetComplete app on mobile phone might be matching.

But, again, it might not, as the text you quoted might be taking precedence² which is why I recommended seeking clarification/permission from trademark owner might be a good idea.

Footnotes

1. one may need to indicate it is a trademark of the GNOME foundation somewhere, though ↩

2. while I might have some little more knowledge of few "intellectual property" laws then average netizen, it is more focused on copyright than trademarks, and definitely IANAL either. ↩

[FloEdelmann]

For reference: icon added in 4303311

[westnordost]

Note the strings were added to the wrong strings.xml file.

Right now, we have two identical strings.xml files, one in androidMain/res/values and one in commonMain/composeResources/values. The one in androidMain currently remains the source, the other is just a copy.
I'll soon change that though (switch it around).