Merged
Conversation
Member
|
hmm, three elements in the icon is not good, it should be at most two elements. I also don't quite follow the change of color. It still concerns bicycle infrastructure. Alternative: Maybe a vertical grey bar with a black keyhole? (On that purple background) |
Member
Member
Member
at least for me this one would be a quite confusing icon |
Member
|
Anyway, since there's no better suggestion and it is somewhat of an improvement over having two related quests that have the same icon and thus could be misunderstood for each other, I'll merge it. However, I'd revert the color to pink. |
Collaborator
Author
|
Ahh, my bad forgot to answer. I actually think your "fire truck" icon looks quite good, but this works for me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This adds a new icon for the AddBicycleBarrierInstallation quest.
The primary reason is that it currently uses the same icon as AddBicycleBarrierType, which can both be asked for the same object, causing potential confusion for users when a answered quests appears to re-appear after answering.
The new icon: