-
-
Notifications
You must be signed in to change notification settings - Fork 256
fix: add software-terms #4432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: add software-terms #4432
Conversation
The idea is to add existing variations: - marshal (verb and noun) - marshals (present tense and plural noun) English: - marshallable (adjective) - marshalling (gerund) - marshalled (past tense) - marshaller (noun) - marshallers (plural noun) American English: - marshalable (adjective) - marshaling (gerund) - marshaled (past tense) - marshaler (noun) - marshalers (plural noun)
- variations of encode are added to the software-terms dictionary
- encode (verb)
- encodes (present tense)
- encoding (gerund and noun)
- encodings (plural noun)
- encoded (past tense)
- encoder (noun)
- encoders (plural noun)
- encodable (adjective)
- encodability (noun)
- variations of decode are also added
- decode (verb)
- decodes (present tense)
- decoding (gerund and noun)
- decodings (plural noun)
- decoded (past tense)
- decoder (noun)
- decoders (plural noun)
- decodable (adjective)
- decodability (noun)
- variations of unencode are added to the software-terms dictionary
- unencode (verb)
- unencodes (present tense)
- unencoded (past tense)
unencode is a neologism, but it is used in the wild.
- package (verb & noun) - packages (plural noun and present tense) - packageability (noun) - packageable (adjective) - packaged (past tense) - packager (noun) - packagers (plural noun) - packaging (gerund and noun) - packagings (plural noun) - unpackage (verb) - unpackages (plural noun and present tense) - unpackageability (noun) - unpackageable (adjective) - unpackaged (past tense) - unpackager (noun) - unpackagers (plural noun)
- wrap (noun and verb) - wraps (plural noun and present tense) - wrappability (noun) - wrappable (adjective) - wrapped (adjective and past tense) - wrapper (noun) - wrappers (plural noun) - wrapping (noun and present participle) - wrappings (plural noun) - unwrap (verb) - unwraps (present tense) - unwrappability (noun) - unwrappable (adjective) - unwrapped (adjective and past tense) - unwrapper (noun) - unwrappers (plural noun) - unwrapping (noun and present participle) - unwrappings (plural noun)
- serializability (noun) - serializable (adjective) - serialization (noun) - serializations (noun) - serialize (verb) - serializes (present tense) - serialized (past tense) - serializing (noun and gerund) - serializer (noun) - serializers (plural noun) - unserializability (noun) - unserializable (adjective) - unserialization (noun) - unserializations (noun) - unserialize (verb) - unserializes (present tense) - unserialized (past tense) - unserializing (gerund) - unserializer (noun) - unserializers (plural noun) - deserializability (noun) - deserializable (adjective) - deserialization (noun) - deserializations (plural noun) - deserialize (verb) - deserializes (present tense) - deserializing (gerund) - deserialized (past tense) - deserializer (noun) - deserializers (plural noun)
- review (noun and verb) - reviews (plural noun and present tense)) - reviewed (adjective) - reviewer (noun) - reviewers (plural noun) - reviewing (gerund) - reviewable (adjective) - reviewability (noun) - unreview (noun and verb) - unreviews (plural noun and present tense) - unreviewed (adjective) - unreviewable (adjective)
- revert (noun and verb) - reverts (plural noun and present tense) - reverted (past tense) - reverting (gerund) - revertible (adjective) - revertable (adjective, less common) - revertability (noun) - unrevert (verb) - unreverts (present tense) - unreverted (past tense) - unreverting (gerund) - unrevertible (adjective)
|
🤔 It might be better to just add these to the appropriate English dictionary. At the moment, the software terms dictionary is always included. Added mixed language terms impacts everyone. |
|
I thought about it this morning, yes. Most will go to en_shared/additional.txt as they are missing in en_CA and en_AU Some might go in en_shared/additional-ise.txt as they are specific to one English flavors. |
|
The main reason I added them to software terms initially is because some words are specific to software. You might use a language that is not English, but use these words anyway. But maybe I'm going too far. Also, these some of the words I'm adding are simply variations of words that are already in software terms. Do you think I should consider to clean up the software-terms file by moving them out of this file to move some of them to en_shared ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering why you not coming back to me 😱 😭, so I came here and saw my comments were still in pending state🤦♂️.
So here we go, I pressed send button 😜😂
| marshallable | ||
| marshalled | ||
| marshaller | ||
| marshallers | ||
| marshalling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question:
Are these good candidate to be added to en_shared/additional-ise.txt
I'm unsure about the en_GB-ise dictionary and the en_shared/additional-ise.txt file purpose
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, including marshalling and marshallable.
| serializability | ||
| serializable | ||
| serialization | ||
| serializations | ||
| serialize | ||
| serialized | ||
| serializer | ||
| serializers | ||
| serializes | ||
| serializing | ||
|
|
||
| unserializability | ||
| unserializable | ||
| unserialization | ||
| unserializations | ||
| unserialize | ||
| unserialized | ||
| unserializer | ||
| unserializers | ||
| unserializes | ||
| unserializing | ||
|
|
||
| deserializability | ||
| deserializable | ||
| deserialization | ||
| deserializations | ||
| deserialize | ||
| deserialized | ||
| deserializer | ||
| deserializers | ||
| deserializes | ||
| deserializing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About these words, they are all in the -ize form.
What do you think about having an en_shared/additional-ize.txt ?
It would be included in en_US, but words from this list would be excluded from en_GB-ise, and maybe others TBD.
I feel like someone enabling en_GB-ise only doesn't want serialize to be accepted as valid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think it is a good idea. Especially since the British dictionary also has the -ize versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The -ize word list is being created #4438
Later, a PR will be opened to add the variants of serialize to this word list
Thank you for the comments. I'll try to answer them. |
It is a balance. That logic is applied to the programming language dictionaries since most of their keywords are English words.
Understood. There are many examples already in the list. I too debated on what to do with derivative words.
Cleaning up software terms is an on-going project. Please remember, removing words tends to get people upset, especially if it breaks their CI/CD pipeline. For this reason, I have started splitting out the word lists, but not deleting terms. |
I feel like we could add a legacy.txt to software-terms.txt what do you think? |
|
Because this PR can be used as a future reference, and because it's still unclear to me where each word I added should go, I plan to close this PR and open smaller ones, focusing on adding one word, and its variations |
I think it is a good idea. |
Replaced by #4453 |
|
I still need to review this one. |
Add/Fix Dictionary
Dictionary: software-terms
Description
References
Checklist
fix:- for minor changes like adding words or fixing spelling issues.feat:- for a significant change like adding a whole new set of words to a dictionary.feat!:- for breaking changes, like file format or licensing changes.chore:- for changes that do not impact the content of dictionaries.