Skip to content

Fix static linking with libde265 on Windows #1507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix static linking with libde265 on Windows #1507

wants to merge 1 commit into from

Conversation

sincos2854
Copy link

Please read #1506

@farindk
Copy link
Contributor

farindk commented Apr 20, 2025

I don't think this is a good solution. LIBDE265_STATIC_BUILD is an implementation detail within libde265 and it should not be exposed or used by any client software (including libheif). Furthermore, this patch assumes that libde265 is built statically exactly when libheif is built statically even though these choices are not related in general.

However, I also do not have a better solution. Support for static linking is not in the main scope of the libraries since it usually indicates a license violation.

@sincos2854
Copy link
Author

I respect your opinion.

If there are no further discussions, please close the pull request without merging it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sincos2854 @farindk