Skip to content

Commit cd447aa

Browse files
[google_sign_in] Convert Android to Pigeon
Replaces the direct method channel implementation with Pigeon. Since `google_sign_in`, unlike most of our plugins, exposes an API that's intended for direct cross-plugin native use, the existing methods are all left in place, but refactored as passthroughs to the new Pigeon versions. To ensure that they aren't broken, the existing Java tests are preserved unchanged (as a "legacy" copy) with `onMethodCall` left in place for now just to allow the tests to continue to run as-is. Since that dispatches to the legacy methods, this keeps the existing coverage of those methods. The new tests are a copy of the legacy tests, minimally translated to use the new Pigeon variants, to ensure continuity of testing to the new version. Part of flutter/flutter#117908
1 parent 1984c73 commit cd447aa

File tree

13 files changed

+2401
-435
lines changed

13 files changed

+2401
-435
lines changed

packages/google_sign_in/google_sign_in_android/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 6.1.17
2+
3+
* Converts method channels to Pigeon.
4+
15
## 6.1.16
26

37
* Updates Guava to version 32.0.1.

packages/google_sign_in/google_sign_in_android/android/src/main/java/io/flutter/plugins/googlesignin/GoogleSignInPlugin.java

Lines changed: 367 additions & 126 deletions
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)