Skip to content

[google_sign_in] Convert to Pigeon #117908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks done
Tracked by #117844
stuartmorgan-g opened this issue Jan 3, 2023 · 1 comment · Fixed by flutter/packages#4941
Closed
2 tasks done
Tracked by #117844

[google_sign_in] Convert to Pigeon #117908

stuartmorgan-g opened this issue Jan 3, 2023 · 1 comment · Fixed by flutter/packages#4941
Assignees
@stuartmorgan-g
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt. p: google_sign_in The Google Sign-In plugin P2 Important issues not at the top of the work list package flutter/packages repository. See also p: labels. team-ecosystem Owned by Ecosystem team triaged-ecosystem Triaged by Ecosystem team

Comments

@stuartmorgan-g
Copy link
Contributor

stuartmorgan-g commented Jan 3, 2023 •
edited
Loading

Part of #117844
@stuartmorgan-g stuartmorgan-g added c: contributor-productivity Team-specific productivity, code health, technical debt. plugin p: google_sign_in The Google Sign-In plugin P2 Important issues not at the top of the work list labels Jan 3, 2023
@stuartmorgan-g stuartmorgan-g mentioned this issue Jan 3, 2023
Closed
12 tasks
@stuartmorgan-g stuartmorgan-g added package flutter/packages repository. See also p: labels. and removed plugin labels May 26, 2023
stuartmorgan-g added a commit to stuartmorgan-g/packages that referenced this issue Jun 29, 2023
@stuartmorgan-g
[google_sign_in] Convert Android to Pigeon
c04ec42 
Replaces the direct method channel implementation with Pigeon.

Since `google_sign_in`, unlike most of our plugins, exposes an API
that's intended for direct cross-plugin native use, the existing methods
are all left in place, but refactored as passthroughs to the new Pigeon
versions. To ensure that they aren't broken, the existing Java tests are
preserved unchanged (as a "legacy" copy) with `onMethodCall` left in
place for now just to allow the tests to continue to run as-is. Since
that dispatches to the legacy methods, this keeps the existing coverage
of those methods.

The new tests are a copy of the legacy tests, minimally translated to
use the new Pigeon variants, to ensure continuity of testing to the new
version.

Part of flutter/flutter#117908
stuartmorgan-g added a commit to stuartmorgan-g/packages that referenced this issue Jun 29, 2023
@stuartmorgan-g
[google_sign_in] Convert Android to Pigeon
446b927 
Replaces the direct method channel implementation with Pigeon.

Since `google_sign_in`, unlike most of our plugins, exposes an API
that's intended for direct cross-plugin native use, the existing methods
are all left in place, but refactored as passthroughs to the new Pigeon
versions. To ensure that they aren't broken, the existing Java tests are
preserved unchanged (as a "legacy" copy) with `onMethodCall` left in
place for now just to allow the tests to continue to run as-is. Since
that dispatches to the legacy methods, this keeps the existing coverage
of those methods.

The new tests are a copy of the legacy tests, minimally translated to
use the new Pigeon variants, to ensure continuity of testing to the new
version.

Part of flutter/flutter#117908
stuartmorgan-g added a commit to stuartmorgan-g/packages that referenced this issue Jun 29, 2023
@stuartmorgan-g
[google_sign_in] Convert Android to Pigeon
cd447aa 
Replaces the direct method channel implementation with Pigeon.

Since `google_sign_in`, unlike most of our plugins, exposes an API
that's intended for direct cross-plugin native use, the existing methods
are all left in place, but refactored as passthroughs to the new Pigeon
versions. To ensure that they aren't broken, the existing Java tests are
preserved unchanged (as a "legacy" copy) with `onMethodCall` left in
place for now just to allow the tests to continue to run as-is. Since
that dispatches to the legacy methods, this keeps the existing coverage
of those methods.

The new tests are a copy of the legacy tests, minimally translated to
use the new Pigeon variants, to ensure continuity of testing to the new
version.

Part of flutter/flutter#117908
@stuartmorgan-g stuartmorgan-g mentioned this issue Jun 29, 2023
Merged
11 tasks
auto-submit bot pushed a commit to flutter/packages that referenced this issue Jul 1, 2023
@stuartmorgan-g
[google_sign_in] Convert Android to Pigeon (#4344)
6ab9a8b 
Replaces the direct method channel implementation with Pigeon.

Since `google_sign_in`, unlike most of our plugins, exposes an API that's intended for direct cross-plugin native use, the existing methods are all left in place, but refactored as passthroughs to the new Pigeon versions. To ensure that they aren't broken, the existing Java tests are preserved unchanged (as a "legacy" copy) with `onMethodCall` left in place for now just to allow the tests to continue to run as-is. Since that dispatches to the legacy methods, this keeps the existing coverage of those methods.

The new tests are a copy of the legacy tests, minimally translated to use the new Pigeon variants, to ensure continuity of testing to the new version.

Part of flutter/flutter#117908
@flutter-triage-bot flutter-triage-bot bot added team-ecosystem Owned by Ecosystem team triaged-ecosystem Triaged by Ecosystem team labels Jul 8, 2023
@stuartmorgan-g stuartmorgan-g self-assigned this Sep 18, 2023
@stuartmorgan-g stuartmorgan-g mentioned this issue Sep 18, 2023
Merged
11 tasks
auto-submit bot pushed a commit to flutter/packages that referenced this issue Sep 18, 2023
@stuartmorgan-g
[google_sign_in] Convert iOS to Pigeon (#4941)
8ec770b 
Replaces the manual method channel code with Pigeon. The Pigeon definition and the Dart code and Dart unit tests are heavily based on the [previous Android migration](#4344).

Fixes flutter/flutter#117908
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 2, 2023
HugoOlthof pushed a commit to moneybird/packages that referenced this issue Dec 13, 2023
@stuartmorgan-g @HugoOlthof
[google_sign_in] Convert iOS to Pigeon (flutter#4941)
5daa758 
Replaces the manual method channel code with Pigeon. The Pigeon definition and the Dart code and Dart unit tests are heavily based on the [previous Android migration](flutter#4344).

Fixes flutter/flutter#117908
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@stuartmorgan-g stuartmorgan-g

Labels
c: contributor-productivity Team-specific productivity, code health, technical debt. p: google_sign_in The Google Sign-In plugin P2 Important issues not at the top of the work list package flutter/packages repository. See also p: labels. team-ecosystem Owned by Ecosystem team triaged-ecosystem Triaged by Ecosystem team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[google_sign_in] Convert iOS to Pigeon stuartmorgan-g/packages
1 participant
@stuartmorgan-g