Skip to content

[google_sign_in] Convert iOS to Pigeon #4941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 18, 2023
Merged

[google_sign_in] Convert iOS to Pigeon #4941

merged 5 commits into from
Sep 18, 2023

Conversation

stuartmorgan-g
Copy link
Contributor

Replaces the manual method channel code with Pigeon. The Pigeon definition and the Dart code and Dart unit tests are heavily based on the previous Android migration.

Fixes flutter/flutter#117908

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

stuartmorgan-g
stuartmorgan-g commented Sep 18, 2023
View reviewed changes
packages/google_sign_in/google_sign_in_ios/ios/Classes/FLTGoogleSignInPlugin.m
}];
} @catch (NSException *e) {
completion(nil, [FlutterError errorWithCode:@"request_scopes" message:e.reason details:e.name]);
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diffs in this file look more extensive than they actually are because of indentation changes. The code here was made by:

  • creating empty stubs for each of the Pigeon protocol methods,
  • moving the body of the relevant if/else if block from handleMethodCall:result: into that method,
  • replacing arg dictionary lookups with the corresponding Pigeon argument (removing some now-unnecessary type-checking code), and
  • replacing result calls with completion calls.

@stuartmorgan-g stuartmorgan-g mentioned this pull request Sep 18, 2023
Closed
2 tasks
tarrinneal
tarrinneal approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@tarrinneal tarrinneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TALOCCITPRBIDSAPIIWIW!

There's a lot of code changed in this pr, but I don't see anything problematic. If it works, it works.

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 18, 2023
@auto-submit auto-submit bot merged commit 8ec770b into flutter:main Sep 18, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 19, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 19, 2023
@engine-flutter-autoroll
8ec770b [google_sign_in] Convert iOS to Pigeon (flutter/packages#4941)
e975ada
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 19, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 19, 2023
@engine-flutter-autoroll
8ec770b [google_sign_in] Convert iOS to Pigeon (flutter/packages#4941)
8eaccb6
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 19, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 19, 2023
@engine-flutter-autoroll
8ec770b [google_sign_in] Convert iOS to Pigeon (flutter/packages#4941)
1786131
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 20, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 20, 2023
@engine-flutter-autoroll
8ec770b [google_sign_in] Convert iOS to Pigeon (flutter/packages#4941)
3897019
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Sep 20, 2023
@engine-flutter-autoroll
Roll Packages from d4e2454 to 51e74b9 (12 revisions) (#135145)
3a78e5c 
flutter/packages@d4e2454...51e74b9

2023-09-19 [email protected] [ios_platform_images] Convert to Pigeon (flutter/packages#4945)
2023-09-19 [email protected] [go_router_builder] Generate initialLocation with StatefulShellBranchConfig (flutter/packages#4880)
2023-09-19 [email protected] Roll Flutter from b7d0e8c to 8936504 (15 revisions) (flutter/packages#4947)
2023-09-18 [email protected] [go_router] Adds on exit (flutter/packages#4699)
2023-09-18 [email protected] [go_router] Fixes RouteInformationParser that does not restore full RouteMatchList if the optionURLReflectsImperativeAPIs is set (flutter/packages#4713)
2023-09-18 [email protected] [file_selector] Fix unknown extensions on macOS (flutter/packages#4946)
2023-09-18 [email protected] [camera_avfoundation] ignore audio samples until first video sample (flutter/packages#4587)
2023-09-18 [email protected] Roll Flutter from 1b18b13 to b7d0e8c (11 revisions) (flutter/packages#4944)
2023-09-18 [email protected] [video_player] isCompleted event. (flutter/packages#4923)
2023-09-18 [email protected] [go_router] Fix an issue in the documentation that used `state.queryParameters` instead of `state.uri.queryParameters` (flutter/packages#4881)
2023-09-18 [email protected] [google_sign_in] Convert iOS to Pigeon (flutter/packages#4941)
2023-09-18 [email protected] Add dashboard link to README (flutter/packages#4902)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@stuartmorgan-g stuartmorgan-g deleted the pigeon-sign-in-ios branch September 21, 2023 13:29
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
@engine-flutter-autoroll @Mairramer
Roll Packages from d4e2454 to 51e74b9 (12 revisions) (flutter#135145)
8a149ab 
flutter/packages@d4e2454...51e74b9

2023-09-19 [email protected] [ios_platform_images] Convert to Pigeon (flutter/packages#4945)
2023-09-19 [email protected] [go_router_builder] Generate initialLocation with StatefulShellBranchConfig (flutter/packages#4880)
2023-09-19 [email protected] Roll Flutter from b7d0e8c to 8936504 (15 revisions) (flutter/packages#4947)
2023-09-18 [email protected] [go_router] Adds on exit (flutter/packages#4699)
2023-09-18 [email protected] [go_router] Fixes RouteInformationParser that does not restore full RouteMatchList if the optionURLReflectsImperativeAPIs is set (flutter/packages#4713)
2023-09-18 [email protected] [file_selector] Fix unknown extensions on macOS (flutter/packages#4946)
2023-09-18 [email protected] [camera_avfoundation] ignore audio samples until first video sample (flutter/packages#4587)
2023-09-18 [email protected] Roll Flutter from 1b18b13 to b7d0e8c (11 revisions) (flutter/packages#4944)
2023-09-18 [email protected] [video_player] isCompleted event. (flutter/packages#4923)
2023-09-18 [email protected] [go_router] Fix an issue in the documentation that used `state.queryParameters` instead of `state.uri.queryParameters` (flutter/packages#4881)
2023-09-18 [email protected] [google_sign_in] Convert iOS to Pigeon (flutter/packages#4941)
2023-09-18 [email protected] Add dashboard link to README (flutter/packages#4902)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
uri-ravzin

This comment was marked as off-topic.

Sign in to view

HugoOlthof pushed a commit to moneybird/packages that referenced this pull request Dec 13, 2023
@stuartmorgan-g @HugoOlthof
[google_sign_in] Convert iOS to Pigeon (flutter#4941)
5daa758 
Replaces the manual method channel code with Pigeon. The Pigeon definition and the Dart code and Dart unit tests are heavily based on the [previous Android migration](flutter#4344).

Fixes flutter/flutter#117908
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uri-ravzin uri-ravzin uri-ravzin left review comments

@tarrinneal tarrinneal tarrinneal approved these changes

@vashworth vashworth Awaiting requested review from vashworth

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: google_sign_in platform-ios
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[google_sign_in] Convert to Pigeon
3 participants
@stuartmorgan-g @uri-ravzin @tarrinneal