Skip to content

[go_router] Fix an issue in the documentation that used state.queryParameters instead of state.uri.queryParameters #4881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 18, 2023
Merged

[go_router] Fix an issue in the documentation that used state.queryParameters instead of state.uri.queryParameters #4881

merged 2 commits into from
Sep 18, 2023

Conversation

ValentinVignal
Copy link
Contributor

Closes flutter/flutter#133773

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@bfritscher
Copy link

This codelab has also the wrong code in it https://firebase.google.com/codelabs/firebase-get-to-know-flutter#4 altought in the step05 code on github it is corrected

@ValentinVignal
Copy link
Contributor Author

This codelab has also the wrong code in it https://firebase.google.com/codelabs/firebase-get-to-know-flutter#4 altought in the step05 code on github it is corrected

I'm not sure this is done in this repo though. @chunhtai How to fix the codelabs?

chunhtai
chunhtai approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai
Copy link
Contributor

This codelab has also the wrong code in it https://firebase.google.com/codelabs/firebase-get-to-know-flutter#4 altought in the step05 code on github it is corrected

I'm not sure this is done in this repo though. @chunhtai How to fix the codelabs?

I will ask internally to see who owns this page

@chunhtai chunhtai requested a review from hannah-hyj September 14, 2023 20:51
hannah-hyj
hannah-hyj approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@hannah-hyj hannah-hyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai
Copy link
Contributor

This codelab has also the wrong code in it https://firebase.google.com/codelabs/firebase-get-to-know-flutter#4 altought in the step05 code on github it is corrected

I'm not sure this is done in this repo though. @chunhtai How to fix the codelabs?

I will ask internally to see who owns this page

It looks like the code is in https://github.com/flutter/codelabs/tree/master_archived/firebase-get-to-know-flutter

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 18, 2023
@auto-submit auto-submit bot merged commit e2dac87 into flutter:main Sep 18, 2023
@ValentinVignal
Copy link
Contributor Author

Thanks @chunhtai, I can make a PR there

@ValentinVignal ValentinVignal mentioned this pull request Sep 19, 2023
Merged
4 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 19, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 19, 2023
@engine-flutter-autoroll
e2dac87 [go_router] Fix an issue in the documentation that used `stat…
bd8b359 
…e.queryParameters` instead of `state.uri.queryParameters` (flutter/packages#4881)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 19, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 19, 2023
@engine-flutter-autoroll
e2dac87 [go_router] Fix an issue in the documentation that used `stat…
7d91b39 
…e.queryParameters` instead of `state.uri.queryParameters` (flutter/packages#4881)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 19, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 19, 2023
@engine-flutter-autoroll
e2dac87 [go_router] Fix an issue in the documentation that used `stat…
488abab 
…e.queryParameters` instead of `state.uri.queryParameters` (flutter/packages#4881)
domesticmouse pushed a commit to flutter/codelabs that referenced this pull request Sep 20, 2023
@ValentinVignal
doc: Use GoRouter state.uri.queryParameters (#1876)
9434012 
Relates to flutter/packages#4881 and
flutter/flutter#133773

This updates the documentation to the latest `go_router` version by
using `state.uri.queryParameters` instead of `state.queryParameters`.

## Pre-launch Checklist

- [x] I read the [Effective Dart: Style] _recently_, and have followed
its advice.
- [x] I signed the [CLA].
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel
channel on [Discord].

<!-- Links -->
[Effective Dart: Style]:
https://dart.dev/guides/language/effective-dart/style
[CLA]: https://cla.developers.google.com/
[Discord]: https://github.com/flutter/flutter/wiki/Chat
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 20, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 20, 2023
@engine-flutter-autoroll
e2dac87 [go_router] Fix an issue in the documentation that used `stat…
8f3fe1b 
…e.queryParameters` instead of `state.uri.queryParameters` (flutter/packages#4881)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Sep 20, 2023
@engine-flutter-autoroll
Roll Packages from d4e2454 to 51e74b9 (12 revisions) (#135145)
3a78e5c 
flutter/packages@d4e2454...51e74b9

2023-09-19 [email protected] [ios_platform_images] Convert to Pigeon (flutter/packages#4945)
2023-09-19 [email protected] [go_router_builder] Generate initialLocation with StatefulShellBranchConfig (flutter/packages#4880)
2023-09-19 [email protected] Roll Flutter from b7d0e8c to 8936504 (15 revisions) (flutter/packages#4947)
2023-09-18 [email protected] [go_router] Adds on exit (flutter/packages#4699)
2023-09-18 [email protected] [go_router] Fixes RouteInformationParser that does not restore full RouteMatchList if the optionURLReflectsImperativeAPIs is set (flutter/packages#4713)
2023-09-18 [email protected] [file_selector] Fix unknown extensions on macOS (flutter/packages#4946)
2023-09-18 [email protected] [camera_avfoundation] ignore audio samples until first video sample (flutter/packages#4587)
2023-09-18 [email protected] Roll Flutter from 1b18b13 to b7d0e8c (11 revisions) (flutter/packages#4944)
2023-09-18 [email protected] [video_player] isCompleted event. (flutter/packages#4923)
2023-09-18 [email protected] [go_router] Fix an issue in the documentation that used `state.queryParameters` instead of `state.uri.queryParameters` (flutter/packages#4881)
2023-09-18 [email protected] [google_sign_in] Convert iOS to Pigeon (flutter/packages#4941)
2023-09-18 [email protected] Add dashboard link to README (flutter/packages#4902)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
@engine-flutter-autoroll @Mairramer
Roll Packages from d4e2454 to 51e74b9 (12 revisions) (flutter#135145)
8a149ab 
flutter/packages@d4e2454...51e74b9

2023-09-19 [email protected] [ios_platform_images] Convert to Pigeon (flutter/packages#4945)
2023-09-19 [email protected] [go_router_builder] Generate initialLocation with StatefulShellBranchConfig (flutter/packages#4880)
2023-09-19 [email protected] Roll Flutter from b7d0e8c to 8936504 (15 revisions) (flutter/packages#4947)
2023-09-18 [email protected] [go_router] Adds on exit (flutter/packages#4699)
2023-09-18 [email protected] [go_router] Fixes RouteInformationParser that does not restore full RouteMatchList if the optionURLReflectsImperativeAPIs is set (flutter/packages#4713)
2023-09-18 [email protected] [file_selector] Fix unknown extensions on macOS (flutter/packages#4946)
2023-09-18 [email protected] [camera_avfoundation] ignore audio samples until first video sample (flutter/packages#4587)
2023-09-18 [email protected] Roll Flutter from 1b18b13 to b7d0e8c (11 revisions) (flutter/packages#4944)
2023-09-18 [email protected] [video_player] isCompleted event. (flutter/packages#4923)
2023-09-18 [email protected] [go_router] Fix an issue in the documentation that used `state.queryParameters` instead of `state.uri.queryParameters` (flutter/packages#4881)
2023-09-18 [email protected] [google_sign_in] Convert iOS to Pigeon (flutter/packages#4941)
2023-09-18 [email protected] Add dashboard link to README (flutter/packages#4902)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chunhtai chunhtai chunhtai approved these changes

@hannah-hyj hannah-hyj hannah-hyj approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: go_router
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[go_router] Change documentation to reflect queryParameters changes
4 participants
@ValentinVignal @bfritscher @chunhtai @hannah-hyj