Cleanup all_but_latest #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikehardy
reviewed
Apr 11, 2021
| for (const {id, head_sha, status} of runningWorkflows) { | ||
| for (const {id, head_sha, status, html_url} of runningWorkflows) { | ||
| console.log('Canceling run: ', {id, head_sha, status, html_url}); | ||
| const res = await octokit.actions.cancelWorkflowRun({ |
Contributor
There was a problem hiding this comment.
missed opportunity to incorporate Promise.all performance optimization - that seemed useful based on other poster's experience
Contributor
There was a problem hiding this comment.
definitely would have to do 2 batches at that point though, while this implementation allows a simple loop
mikehardy
added a commit
to mikehardy/flutterfire
that referenced
this pull request
Apr 11, 2021
Upstream has integrated the "all_but_latest" feature - https://github.com/styfle/cancel-workflow-action/releases/tag/0.9.0 styfle/cancel-workflow-action#35 styfle/cancel-workflow-action#67
10 tasks
Salakar
pushed a commit
to firebase/flutterfire
that referenced
this pull request
Apr 11, 2021
Upstream has integrated the "all_but_latest" feature - https://github.com/styfle/cancel-workflow-action/releases/tag/0.9.0 styfle/cancel-workflow-action#35 styfle/cancel-workflow-action#67
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #35