🐛(frontend) fix bind-mount hiding node_modules #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexgarden92160
force-pushed
the
fix/frontend-dev-bind-mount
branch
from
694ec3f to
de82d0b
Compare
Narrow the bind-mount to ./src/frontend/apps/drive so that the node_modules folder created during the image build remains available inside the container. Solves: /bin/sh: next: not found when running make run-with-frontend. Signed-off-by: Alexandre Garden <[email protected]>
alexgarden92160
force-pushed
the
fix/frontend-dev-bind-mount
branch
from
de82d0b to
84dc3b8
Compare
alexgarden92160
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Narrow the bind-mount to ./src/frontend/apps/drive so that the node_modules folder created during the image build remains available inside the container. Solves: /bin/sh: next: not found when running make run-with-frontend.
Closes: #189
Purpose
Running the project with
make run-with-frontendmade the containerdrive-frontend-dev-1exit immediately:$ next dev
/bin/sh: next: not found
The full
./src/frontend → /home/frontend/bind-mount hid thenode_modulesdirectory produced during the Docker build stage, removingnode_modules/.bin/nextfrom the container’sPATH.Proposal
Bind-mount only the sources that need hot reload (
apps/drive) andstop masking the dependencies installed in the image.