Skip to content

✨(global) add customization to feedbacks #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 3, 2025
Merged

✨(global) add customization to feedbacks #248

merged 3 commits into from
Jul 3, 2025

Conversation

NathanVss
Copy link
Contributor

No description provided.

@NathanVss NathanVss changed the title Feat/custom feedback ✨(global) add customization to feedbacks Jul 2, 2025
@NathanVss NathanVss force-pushed the feat/custom-feedback branch from abe3789 to 69ec3f9 Compare July 2, 2025 12:44
@NathanVss NathanVss force-pushed the feat/custom-feedback branch 3 times, most recently from a71a30d to bedbbf9 Compare July 2, 2025 13:06
lunika
lunika reviewed Jul 2, 2025
View reviewed changes
PanchoutNathan
PanchoutNathan approved these changes Jul 2, 2025
View reviewed changes
@NathanVss NathanVss force-pushed the feat/custom-feedback branch 2 times, most recently from e4ac07b to 581dd35 Compare July 2, 2025 17:01
NathanVss added 2 commits July 3, 2025 09:31
@NathanVss
✨(back) add frontend envvar to settings and config
2706d4b 
We need more envvar to pass to the frontend to allow greater
customization for instances of Drive.
@NathanVss
✨(front) add more config variables
f9aff66 
We need to provide more customization for the frontend regarding
feedback links.
@NathanVss NathanVss force-pushed the feat/custom-feedback branch from 581dd35 to 4a42c84 Compare July 3, 2025 07:31
@NathanVss
✨(front) add customization to feedbacks
072a6dc 
Let's implement the freshly added envvar to the feedback feature.
@NathanVss NathanVss force-pushed the feat/custom-feedback branch from 4a42c84 to 072a6dc Compare July 3, 2025 07:36
sylvinus
sylvinus approved these changes Jul 3, 2025
View reviewed changes
Copy link
Member

@sylvinus sylvinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! raises the question of further customization (at which point do we inject custom files directly in the build via config, vs. having a growing number of env vars and semi-specific code in the repo)

@lunika
Copy link
Member

lunika commented Jul 3, 2025 •
edited
Loading

IMO we have to go in the direction of having a configuration file. This is what is made on docs and allow us to customize lot of think in the interface

@NathanVss NathanVss merged commit 072a6dc into main Jul 3, 2025
19 of 20 checks passed
@NathanVss NathanVss deleted the feat/custom-feedback branch July 3, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sylvinus sylvinus sylvinus approved these changes

@lunika lunika lunika approved these changes

@PanchoutNathan PanchoutNathan PanchoutNathan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NathanVss @lunika @sylvinus @PanchoutNathan