Open
Conversation
mamazu
force-pushed
the
request_parameter_rector
branch
2 times, most recently
from
6b6aa60 to
61cec13
Compare
mamazu
force-pushed
the
request_parameter_rector
branch
from
61cec13 to
919cc9c
Compare
mamazu
force-pushed
the
request_parameter_rector
branch
from
919cc9c to
afce6b0
Compare
mamazu
force-pushed
the
request_parameter_rector
branch
from
efedb3c to
4778757
Compare
mamazu
force-pushed
the
request_parameter_rector
branch
from
5f77b48 to
f3fdce1
Compare
mamazu
force-pushed
the
request_parameter_rector
branch
from
f3fdce1 to
bd64618
Compare
Author
|
I'm pretty sure that those refactorings can also be done with 2.6 since we're not relying on classes that have been added. In fact in 3.0 some of the classes have been removed. @alexander-schranz Maybe we even should put it into the Upgrade.md to run the rector. But we can discuss that tomorrow. |
mamazu
force-pushed
the
request_parameter_rector
branch
from
c66d021 to
21da203
Compare
mamazu
commented
Nov 21, 2025
Comment on lines
+58
to
+60
| if (!$this->nodeTypeResolver->isMethodStaticCallOrClassMethodObjectType($node, $objectType)) { | ||
| return null; | ||
| } |
Author
There was a problem hiding this comment.
Does this not need a check if it's an "whereNot" call?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Method Renames
Adding method renames to the 2.6 version, as this can already be done in the old version. Otherwise they would be part of the UP_TO_2_6 migration.
RequestParameterTrait
I've added a rector to refactor this. Mostly cause I wanted to try to use rector but also to help the upgrade that people want to make. The generated code is not the most optimal (as we can't determine the parameter is from) but it works the same as before.
Seeing that the
MissingParameterExceptionis also deprecated it has now been replaced with anInvalidArgumentExceptionwhich will result in a 500 error code.Related: sulu/sulu#7815
Replacing deprecated ListRepresentation
Now it automatically refactors it to the PaginatedVersion with additional
intcasts in case of defective types.Adding Sulu Level 3.0
(stolen from #18)
TODO