Literal Header Field representation with invalid index#113
Merged
summerwind merged 1 commit intosummerwind:masterfrom Jun 2, 2020
Merged
Conversation
summerwind
approved these changes
Jun 2, 2020
Owner
summerwind
left a comment
summerwind
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
Feedback from the implementation is always welcome 😄
Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current hpack/2.3.3 test covers an invalid index on the "Indexed Header Field". This adds the case of an invalid index on the "Literal Header Field with Incremental Indexing".
We recently found a bug with this case on our project ( apache/trafficserver#6786 ). It'd be great if h2spec covers this case.