Skip to content

Feature/release please #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

diegofesanto
Copy link
Contributor

@diegofesanto diegofesanto commented Apr 13, 2025

What kind of change does this PR introduce?

feature, setup automatic release with release-please

What is the new behavior?

Generate a release PR by release-please,
#56

@diegofesanto diegofesanto requested a review from grdsdev April 14, 2025 21:01
@@ -0,0 +1,3 @@
{
".": "7.2.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be 7.1.0 since it is the last version? just like the Realtime.csproj file?

Copy link
Contributor Author

@diegofesanto diegofesanto Apr 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to change this value after some tests, but, this value will be changed by the release-please...

Anyway I will put the same value from csproj to avoid some kind of issue with release-please

@grdsdev
Copy link
Collaborator

grdsdev commented Apr 25, 2025

Also need to make sure the https://github.com/supabase-community/realtime-csharp/blob/master/.github/workflows/release.yml runs after the release-please gets merged, the Python library uses a similar approach https://github.com/supabase/supabase-py/blob/main/.github/workflows/ci.yml#L62-L109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants