Skip to content

Improve composition #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 25, 2021

Conversation

sduduzog
Copy link
Collaborator

@sduduzog sduduzog commented Oct 19, 2021

This PR introduces a couple of helping composables for Vue3 and Vue2+composition-api, namely:

  • useSupabase
  • useSupabaseAuth
  • useSupabaseStorage

Adds type declarations which solves the issue supabase-community/nuxt-supabase#11 for vue projects using vue-class-components, inevitably nuxt projects too

Adds easily configurable example projects for Vue2 and Vue3 enabling anyone to quickly play around with the plugin

It also adds configuration setup for eslint and prettier for basic linting and code formatting

TODO

  • Create test project on supabase.io for testing on different project setups
  • Create a repository for testing Vue2 + composition api applications
  • Create a repository for testing Vue3 + vite applications

Note
The examples added to the project are not at all perfect, but they get the job done. They provided me with the quickest way to test changes added to this PR. Also, they aren't and shouldn't be set in stone. if there's a better way to achieve such a task, we should go for it.

@sduduzog sduduzog changed the title Improve composition (WIP) Improve composition Oct 20, 2021
@sduduzog sduduzog marked this pull request as draft October 21, 2021 07:42
@sduduzog sduduzog marked this pull request as ready for review October 21, 2021 07:42
@sduduzog
Copy link
Collaborator Author

@scottrobertson I'm interested on your take on the example projects I included

Copy link

@florian-lefebvre florian-lefebvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link
Contributor

@scottrobertson scottrobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Not a fan of example projects as we need to keep it up to date, but I think it's simple enough.

Thanks for this!

@scottrobertson
Copy link
Contributor

@sduduzog can you merge these, or do you want me to?

@sduduzog
Copy link
Collaborator Author

@scottrobertson Please do, I actually don't have write access (hopefully yet)

@scottrobertson
Copy link
Contributor

Oh I thought you did. I asked @kiwicopple to give you it.

@scottrobertson scottrobertson merged commit 56edca7 into supabase-community:main Oct 25, 2021
@scottrobertson
Copy link
Contributor

@sduduzog to trigger a release, do another PR with the version bumped, then I can merge and click release :)

@sduduzog sduduzog deleted the improve-composition branch November 1, 2021 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants