Rfc/dump #3
Closed
Rfc/dump #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We would like to create a basic CLI for Supabase. At this stage we can assume that the user won't need to create orgs/projects from the CLI, but they will need to: - develop locally - push database migrations to their Postgres database
kiwicopple
commented
Feb 14, 2021
Comment on lines
+7
to
+13
| alter table "public"."users" add column | ||
| "data" | ||
| jsonb -- type | ||
| default -- default | ||
| ; | ||
| comment on column "public"."users"."data" is | ||
| ""; |
There was a problem hiding this comment.
The trickiest part of making the models "clean" seems to be figuring out how to group the comments with the column.
This looks clean:
create table users (
id uuid primary_key,
first_name text,
last_name text
)but then the comments have to sit below the actual table:
create table users (
id uuid primary_key,
first_name text,
last_name text
)
comment on column "public"."users"."firstname" is "Some comment";
comment on column "public"."users"."lastname" is "Some comment";As a result it may be better to create all the columns in separate alter statements
There was a problem hiding this comment.
The problem with the ALTER COLUMNs is that they're too verbose. I think that our structure should make the point that "SQL is code". Verbosity won't aid in that goal, and instead it discourages looking into the generated SQL.
So the comments at the bottom look better to me.
Closed
|
Closing this as we're transitioning to the Go CLI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Mocks up a dump concept