[wip] refactor: accept httpx client #201
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@silentworks was doing a few tests for solving supabase/supabase-py#1091 issue, can you check this changes? I think this is the way, we should do something similar on all libs. |
silentworks
reviewed
May 10, 2025
| http2=True, | ||
| ) | ||
|
|
||
| if timeout is not None: |
There was a problem hiding this comment.
I like the idea of deprecating these and suggesting to handle this in your httpx client yourself.
silentworks
reviewed
May 10, 2025
| self._client = httpx | ||
| self._client.base_url = self.url | ||
| self._client.headers = self.headers | ||
| self._client.follow_redirects = True |
There was a problem hiding this comment.
I don't believe these params should be set besides the base_url and headers. The others should be handled by the developer when they decide to use their own httpx client.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix, feature, docs update, ...
What is the current behavior?
Please link any relevant issues here.
What is the new behavior?
Feel free to include screenshots if it includes visual changes.
Additional context
Add any other context or screenshots.