POC: typescript generator #260
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiwicopple
commented
May 30, 2022
| @@ -62,7 +64,7 @@ | |||
| "pkg": "^5.5.2", | |||
| "rimraf": "^3.0.2", | |||
| "ts-jest": "^27.0.5", | |||
| "ts-node-dev": "^1.1.6", | |||
| "ts-node-dev": "^2.0.0", | |||
There was a problem hiding this comment.
I'm on node v16 now - needed to bump this
|
|
||
| `.trim() | ||
|
|
||
| export default template |
There was a problem hiding this comment.
This is the main template, based on the spec in the RFC
Comment on lines
+16
to
+18
| const { data: tables } = await pgMeta.tables.list({}) | ||
| const { data: functions } = await pgMeta.functions.list({}) | ||
| const definition = ejs.render(template, { tables, functions }) |
There was a problem hiding this comment.
pgMeta already has the data in JSON format, so we have done the hard work - we just need to pass the data to the template
| const { data: functions } = await pgMeta.functions.list({}) | ||
| const definition = ejs.render(template, { tables, functions }) | ||
|
|
||
| return reply.header('content-type', responseFormat).send(definition) |
There was a problem hiding this comment.
then we can send the data in text/plain, so that the CLI can dump it to disk (or we can display it on the Dashboard etc)
Result:
There was a problem hiding this comment.
Do we need configurable responseFormat? Or can we make it text/plain always?
|
Closed in favor of #269 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft/POC