chore: Types improvements. #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
soedirgo
reviewed
Oct 21, 2020
There was a problem hiding this comment.
Looks good @thorwebdev, didn't occur to me to just cast the result of single...
Co-authored-by: Bobbie Soedirgo <[email protected]>
soedirgo
approved these changes
Oct 21, 2020
kiwicopple
reviewed
Oct 21, 2020
| @@ -68,8 +68,8 @@ export default class PostgrestTransformBuilder<T> extends PostgrestBuilder<T> { | |||
| * Retrieves only one row from the result. Result must be one row (e.g. using | |||
| * `limit`), otherwise this will result in an error. | |||
| */ | |||
| single(): PostgrestTransformBuilder<T> { | |||
| single(): PromiseLike<PostgrestSingleResponse<T>> { | |||
|
Nice one Thor, Bobbie! Team work makes the dream work |
|
🎉 This PR is included in version 0.21.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @soedirgo @kiwicopple (I might need some help with updating the test snapshots)
What kind of change does this PR introduce?
PostgrestResponsedata always an arrayPostgrestSingleResponseand makesinglereturnPromiseLike<PostgrestSingleResponse<T>>singlehas to be called at the very end of the method chain in a TypeScript context.PostgrestResponseis correctly assigned as the return type ofonfulfilledcallback.Additional context
I've tested this in a TypeScript project:
