-
-
Notifications
You must be signed in to change notification settings - Fork 160
Bump superagent from 5.3.1 to 6.1.0 #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump superagent from 5.3.1 to 6.1.0 #91
Conversation
Bumps [superagent](https://github.com/visionmedia/superagent) from 5.3.1 to 6.1.0. - [Release notes](https://github.com/visionmedia/superagent/releases) - [Changelog](https://github.com/visionmedia/superagent/blob/master/HISTORY.md) - [Commits](ladjs/superagent@v5.3.1...v6.1.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
@soedirgo perhaps you can check this out as part of your updated fork? I can't see any breaking changes in superagent |
I actually switched to axios in my fork. I'll make a draft PR highlighting this and some other changes soon and we can discuss this there. |
If we do axios in postgrest-js then we have to do axios everywhere (so that we don't end up with dependency bloat). Is there any reason why? |
There wasn't a big reason, now that we no longer extend superagent's I'm not aware of other tools we have that already use superagent (other than supabase-js), but it wouldn't be difficult to switch back if you want. |
Actually you're right - there aren't many places besides postgrest-js, supabase-js. Soon we will do a gotrue-js (their client works with micro-api-client, so we have to switch anyway). I actually prefer axios, but I think we will have to go through all the docs/code and change
to
right? |
The previous version will work fine in JS, I made a change that makes it work here, but yeah, the compiler will complain in TypeScript. Unless I can find a way to modify the type somehow... Edit: A simple way would be to extend AxiosResponse and add the |
I think if we are going to make a change, we'd be better off going with a fetch polyfill, like Next.js did here: https://nextjs.org/blog/next-9-4#improved-built-in-fetch-support This would require some work to be backwards compatible. Otherwise I'm not sure if there is a benefit to switching - i prefer axios's API, but my preference isn't a benefit to developers, as they don't see the request lib's API. Thoughts? |
I like the fetch polyfill idea (apparently it wasn't within my radar). I'm looking at isomorphic-unfetch, which makes for a significant bundle size difference: superagent (10.1 kB), axios (4.6 kB), isomorphic-unfetch (582 B). superagent's size ballooned in 6.1.0 for some reason. Fetch uses a similar response format, so back-compat shouldn't be an issue. We can use a custom Response type so |
Let's close this in favour of your work in the TypeScript branch |
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps superagent from 5.3.1 to 6.1.0.
Release notes
Sourced from superagent's releases.
Commits
1277a88
v6.1.0aa43b3d
fix: use qs to serialize form data in browser (#1591)f817806
Create FUNDING.yml6a31af9
docs: updated docs, set to master branch484f890
chore: updated docsa12e784
v6.0.0d68907b
fix: bump deps, fixed linting, specific retry approach44fadf9
fix: fixed content-type case-sensitivity (closes #1572)e88a13f
Add mention of bearer auth to docs (#1583)a009ace
Update jQuery in tail.html (#1582)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labels
will set the current labels as the default for future PRs for this repo and language@dependabot use these reviewers
will set the current reviewers as the default for future PRs for this repo and language@dependabot use these assignees
will set the current assignees as the default for future PRs for this repo and language@dependabot use this milestone
will set the current milestone as the default for future PRs for this repo and language@dependabot badge me
will comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in your Dependabot dashboard: