Skip to content

[POC] chore: use getHeaders #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[POC] chore: use getHeaders #67

wants to merge 1 commit into from

Conversation

alaister
Copy link
Member

Implements a new getHeaders function instead of a static headers object.

This relates to supabase/auth-js#285

This can also be made as a non-breaking change by allowing an object to still be passed in place of the function, but I think since we're already making some breaking changes, we should favour API simplicity.

@alaister alaister requested review from inian and kangmingtay May 23, 2022 07:13
@alaister alaister changed the title [POC]: chore: use getHeaders [POC] chore: use getHeaders May 23, 2022
@alaister alaister changed the base branch from main to next May 30, 2022 04:45
@alaister
Copy link
Member Author

alaister commented Jun 4, 2022

This change is no longer needed as we've decided to use a custom fetch implementation in order to not have to change any of the sublibraries.

@alaister alaister closed this Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant