fix: createBucket pass through all values returned by backend #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of cherry picking only name - we still do this in the types though. also ensures data is always an object. Fixes #6
alaister
approved these changes
Aug 10, 2022
alaister
reviewed
Aug 10, 2022
|
The backend is only returning the name of the new bucket and not the entire Bucket object. If backend returns the full object, we could have just had the return type as Fixed tests! |
alaister
approved these changes
Aug 10, 2022
|
🎉 This PR is included in version 1.8.0-next.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.0.0-rc.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of cherry picking only name - we still do this in the types though.
also ensures data is always an object.
Fixes #6