Segmentation fault when using fly server (node version >=10.4)

[nick-potts]

Just using the example code from the docs.

Generating Webpack config...
Compiling app w/ options: { watch: true, uglify: false }
new runtime, app: /Users/nick.potts/Documents/worker-performance-examples/time 
PID 4992 received SIGSEGV for address: 0x73
0   segfault-handler.node               0x00000001083603e8 _ZL16segfault_handleriP9__siginfoPv + 312
1   libsystem_platform.dylib            0x00007fff5ae17f5a _sigtramp + 26
2   ???                                 0x00007ffeefbfd130 0x0 + 140732920746288
Segmentation fault: 11

[mrkurt]

Which OS and node version was this? If you can try a new node version, 10.4 10.3 or 8.9 (I think) might help.

[nick-potts]

macOS 10.13.5, node/10.4.1

[jeromegn]

10.3 works, but I think anything higher segfaults. I believe it’s an issue with isolated-vm, a package we use. I can open a ticket there.

…

-- Jérôme Gravel-Niquet

On July 2, 2018 at 8:53:59 PM, Nick ***@***.***) wrote: macOS 10.13.5, node/10.4.1 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#101 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AACpPf37HgmT0aaQ_14GOhtL4pewyQQJks5uCsCngaJpZM4VAH5i> .

[nick-potts]

Yep, that's my conclusion too.

/Users/nick.potts/fly/src/v8env.ts:29
  v8EnvSnapshot = ivm.Isolate.createSnapshot([{
Error: Cannot find module "whatwg-streams/reference-implementation/lib/readable-stream"

[jeromegn]

@laverdet any ideas?

[jeromegn]

@nick-potts you need to git submodule init and git submodule update

[nick-potts]

That's fixed the error above, now I'm back to the seg fault. I've joined the slack channel.

[laverdet]

The segfault-handler module on npm (in use by fly) actually causes segfaults. I submitted a patch to the author in April and haven't heard anything about it: ddopson/node-segfault-handler#49

[laverdet]

Correction: I didn't submit a patch but the problem is clear :)

[mrkurt]

@nick-potts did you happen to nuke node_modules and reinstall from npm after you downgraded to 10.3? I just tried a fresh 10.3 install + fresh npm install to double check and it works here.

[laverdet]

Further correction: now that I remember the issue with that package it's not that segfault-handler causes segfaults, it just makes them harder to track. Could you please drop that package and post the resulting stack trace?

[nick-potts]

10.3 + npm rebuild + restart of the dev machine fixed it for me. Removing segfault-handler just resulted in the stack trace to not be logged, but I'm not familiar with the code base.