feat: use checkboxes to render multi-select field#4380
Merged
Conversation
Signed-off-by: Lucas Pinheiro <lucas@superplane.com>
|
👋 Commands for maintainers:
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1c227fb. Configure here.
Signed-off-by: Lucas Pinheiro <lucas@superplane.com>
Contributor
Author
|
👍 |
WashingtonKK
pushed a commit
to WashingtonKK/superplane
that referenced
this pull request
Apr 27, 2026
For integration setup flow, I want an element that displays a bunch of options and the user can on / off them. Since we already have a multi-select element, just added a type option to render it differently. For example, this is how the the `semaphore.onPipelineDone` trigger result filter looks like with it: <img width="623" height="448" alt="Screenshot 2026-04-24 at 17 07 14" src="https://github.com/user-attachments/assets/b9a901ed-e6eb-45b9-9f70-623c15abf05f" /> --- This PR is just adding the ability, not updating any components to use it. To me, this looks a lot better than the current default, but I didn't want to update anything else yet. We can make it the default behavior later on. --------- Signed-off-by: Lucas Pinheiro <lucas@superplane.com> Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
re-pixel
pushed a commit
to re-pixel/superplane
that referenced
this pull request
May 4, 2026
For integration setup flow, I want an element that displays a bunch of options and the user can on / off them. Since we already have a multi-select element, just added a type option to render it differently. For example, this is how the the `semaphore.onPipelineDone` trigger result filter looks like with it: <img width="623" height="448" alt="Screenshot 2026-04-24 at 17 07 14" src="https://github.com/user-attachments/assets/b9a901ed-e6eb-45b9-9f70-623c15abf05f" /> --- This PR is just adding the ability, not updating any components to use it. To me, this looks a lot better than the current default, but I didn't want to update anything else yet. We can make it the default behavior later on. --------- Signed-off-by: Lucas Pinheiro <lucas@superplane.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For integration setup flow, I want an element that displays a bunch of options and the user can on / off them. Since we already have a multi-select element, just added a type option to render it differently.
For example, this is how the the
semaphore.onPipelineDonetrigger result filter looks like with it:This PR is just adding the ability, not updating any components to use it. To me, this looks a lot better than the current default, but I didn't want to update anything else yet. We can make it the default behavior later on.