Connect to MySQL 8 binlog users without requiring TLS - #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MySQL 8 often authenticates with caching_sha2_password, and surreal-sync could already handle that when TLS was on or the password was already cached.
You can now also connect over a plain connection when MySQL asks for a full password check, so a normal MySQL 8 replication user works without forcing TLS or switching to an older password plugin.
The MySQL binlog source docs spell out which authentication paths are supported, so you know what to expect when setting up the replication user.
Intends to cover the first fix mentioned in #121