chore: update currentSingleElement to be a union type that includes undefined #9640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4728,7 +4728,7 @@ export class SurveyModel extends SurveyElementCore | |||
| } | |||
| return res; | |||
| } | |||
| public get currentSingleElement(): IElement { | |||
| public get currentSingleElement(): IElement|undefined { | |||
| return !this.isShowingPreview ? this.currentSingleElementValue : undefined; | |||
| } | |||
| public set currentSingleElement(val: IElement) { | |||
There was a problem hiding this comment.
Angular give the compiling error:
error TS2380: The return type of a 'get' accessor must be assignable to its 'set' accessor type
Type 'undefined' is not assignable to type 'IElement'.
set currentSingleElement(val: IElement|undefined)
There was a problem hiding this comment.
Seems like a very old typescript version?
Edit: it's an ancient version of angular: https://angular.dev/reference/versions
I'd propose dropping all unsupported versions of Angular and updating to TS >= 5.2.
Holding back your whole code base to support frameworks that no longer receive support makes no sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type for
currentSingleElementsuggests it is always set, but it is not.